Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc

Issue 1835833004: Added missing TODOs in the beamformer unit test code. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Moved one of the TODOs to a more appropriate place Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc
diff --git a/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc b/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc
index 552422ce3aa894af9e52ef3248b7bb6a68c0858b..8242571c7149e31bec341af2380f8710cad478ea 100644
--- a/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc
+++ b/webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc
@@ -123,6 +123,8 @@ void RunBitExactnessTest(int sample_rate_hz,
output_reference, capture_output, kTolerance));
}
+// TODO(peah): Add bitexactness tests for scenarios with more than 2 input
+// channels.
std::vector<Point> CreateArrayGeometry(int variant) {
std::vector<Point> array_geometry;
switch (variant) {
@@ -247,6 +249,9 @@ TEST(NonlinearBeamformerTest, InterfAnglesTakeAmbiguityIntoAccount) {
}
}
+// TODO(peah): Reenable all bitexactness tests once the division-by-zero issue
+// has been resolved.
+
// TODO(peah): Investigate why the nonlinear_beamformer.cc causes a DCHECK in
// this setup.
TEST(BeamformerBitExactnessTest,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698