webrtc/voice_engine/test/auto_test/voe_conference_test.cc - Issue 1835053002: Change default timestamp to 64 bits in all webrtc directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/test/auto_test/voe_conference_test.cc

Issue 1835053002: Change default timestamp to 64 bits in all webrtc directories. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Add TODO for timestamp. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/voice_engine/test/auto_test/fakes/loudest_filter.cc ('k') | webrtc/voice_engine/test/auto_test/voe_output_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/voice_engine/test/auto_test/voe_conference_test.cc

diff --git a/webrtc/voice_engine/test/auto_test/voe_conference_test.cc b/webrtc/voice_engine/test/auto_test/voe_conference_test.cc

index c70d92a94627f467569701ec5a91d467c06d88ad..946eb4e525f8a6f10842b38a1f463cf7dcf27789 100644

--- a/webrtc/voice_engine/test/auto_test/voe_conference_test.cc

+++ b/webrtc/voice_engine/test/auto_test/voe_conference_test.cc

@@ -72,15 +72,15 @@ TEST(VoeConferenceTest, RttAndStartNtpTime) {

const int kStatsRequestIntervalMs = 1000;

const int kStatsBufferSize = 3;

- uint32_t deadline = rtc::TimeAfter(kMaxRunTimeMs);

+ int64_t deadline = rtc::TimeAfter(kMaxRunTimeMs);

// Run the following up to |kMaxRunTimeMs| milliseconds.

int successive_pass = 0;

webrtc::CallStatistics stats_1;

webrtc::CallStatistics stats_2;

std::queue<Stats> stats_buffer;

- while (rtc::TimeIsLater(rtc::Time(), deadline) &&

- successive_pass < kNeedSuccessivePass) {

+ while (rtc::TimeMillis() < deadline &&

+ successive_pass < kNeedSuccessivePass) {

webrtc::SleepMs(kStatsRequestIntervalMs);

EXPECT_TRUE(trans.GetReceiverStatistics(id_1, &stats_1));