webrtc/voice_engine/test/auto_test/fakes/loudest_filter.cc - Issue 1835053002: Change default timestamp to 64 bits in all webrtc directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/voice_engine/test/auto_test/fakes/loudest_filter.cc

Issue 1835053002: Change default timestamp to 64 bits in all webrtc directories. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Add TODO for timestamp. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/voice_engine/test/auto_test/fakes/loudest_filter.h ('k') | webrtc/voice_engine/test/auto_test/voe_conference_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/voice_engine/test/auto_test/fakes/loudest_filter.cc

diff --git a/webrtc/voice_engine/test/auto_test/fakes/loudest_filter.cc b/webrtc/voice_engine/test/auto_test/fakes/loudest_filter.cc

index d4438a4e158547b2a4ded9f7405ed7db50d525b7..1787915356aa434af5a2f13ae59e4556cd90660c 100644

--- a/webrtc/voice_engine/test/auto_test/fakes/loudest_filter.cc

+++ b/webrtc/voice_engine/test/auto_test/fakes/loudest_filter.cc

@@ -14,11 +14,10 @@

namespace voetest {

-void LoudestFilter::RemoveTimeoutStreams(uint32_t time_ms) {

+void LoudestFilter::RemoveTimeoutStreams(int64_t time_ms) {

auto it = stream_levels_.begin();

while (it != stream_levels_.end()) {

- if (rtc::TimeDiff(time_ms, it->second.last_time_ms) >

- kStreamTimeOutMs) {

+ if (rtc::TimeDiff(time_ms, it->second.last_time_ms) > kStreamTimeOutMs) {

stream_levels_.erase(it++);

} else {

++it;

@@ -41,7 +40,7 @@ unsigned int LoudestFilter::FindQuietestStream() {

}

bool LoudestFilter::ForwardThisPacket(const webrtc::RTPHeader& rtp_header) {

- uint32_t time_now_ms = rtc::Time();

+ int64_t time_now_ms = rtc::TimeMillis();

RemoveTimeoutStreams(time_now_ms);

int source_ssrc = rtp_header.ssrc;