Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1546)

Issue 1834233002: Update QuicTransportChannel to latest version of libquic (Closed)

Created:
4 years, 8 months ago by mikescarlett
Modified:
4 years, 8 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update QuicTransportChannel to latest version of libquic This CL integrates recent Chromium changes that were merged into https://github.com/devsisters/libquic/tree/master. It also performs minor cleanup, such as removing accidental usage of Chromium logging symbols (e.g. LOG(INFO), LOG(ERROR) instead of LOG(LS_INFO), LOG(LS_ERROR)) and using Chromium's scoped_ptr instead of rtc::scoped_ptr. BUG= Committed: https://crrev.com/f53776849710d511a97ea39ee17e4437aaaef85d Cr-Commit-Position: refs/heads/master@{#12146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -145 lines) Patch
M webrtc/p2p/quic/quicconnectionhelper.h View 4 chunks +8 lines, -2 lines 0 comments Download
M webrtc/p2p/quic/quicconnectionhelper.cc View 4 chunks +17 lines, -5 lines 0 comments Download
M webrtc/p2p/quic/quicconnectionhelper_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M webrtc/p2p/quic/quicsession.h View 4 chunks +4 lines, -6 lines 0 comments Download
M webrtc/p2p/quic/quicsession.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M webrtc/p2p/quic/quicsession_unittest.cc View 11 chunks +41 lines, -51 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel.h View 3 chunks +7 lines, -2 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel.cc View 23 chunks +54 lines, -45 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/p2p/quic/reliablequicstream.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/quic/reliablequicstream_unittest.cc View 7 chunks +15 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mikescarlett
4 years, 8 months ago (2016-03-28 17:39:04 UTC) #4
pthatcher1
lgtm
4 years, 8 months ago (2016-03-29 00:46:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834233002/1
4 years, 8 months ago (2016-03-29 17:05:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 19:14:59 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 19:15:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f53776849710d511a97ea39ee17e4437aaaef85d
Cr-Commit-Position: refs/heads/master@{#12146}

Powered by Google App Engine
This is Rietveld 408576698