Update QuicTransportChannel to latest version of libquic

webrtc/p2p/quic/quicsession_unittest.cc

 /*
  *  Copyright 2016 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 10 matching lines @@
 #include "net/quic/crypto/quic_crypto_client_config.h"
 #include "net/quic/crypto/quic_crypto_server_config.h"
 #include "net/quic/quic_crypto_client_stream.h"
 #include "net/quic/quic_crypto_server_stream.h"
 #include "webrtc/base/common.h"
 #include "webrtc/base/gunit.h"
 #include "webrtc/p2p/base/faketransportcontroller.h"
 #include "webrtc/p2p/quic/quicconnectionhelper.h"
 #include "webrtc/p2p/quic/reliablequicstream.h"
 
-using net::IPAddressNumber;
+using net::IPAddress;
 using net::IPEndPoint;
+using net::PerPacketOptions;
 using net::Perspective;
 using net::ProofVerifyContext;
 using net::ProofVerifyDetails;
 using net::QuicByteCount;
 using net::QuicClock;
 using net::QuicConfig;
 using net::QuicConnection;
 using net::QuicCryptoClientConfig;
 using net::QuicCryptoServerConfig;
 using net::QuicCryptoClientStream;
@@ skipping 10 matching lines @@
 
 using cricket::FakeTransportChannel;
 using cricket::QuicConnectionHelper;
 using cricket::QuicSession;
 using cricket::ReliableQuicStream;
 using cricket::TransportChannel;
 
 using rtc::Thread;
 
 // Timeout for running asynchronous operations within unit tests.
-const int kTimeoutMs = 1000;
+static const int kTimeoutMs = 1000;
 // Testing SpdyPriority value for creating outgoing ReliableQuicStream.
-const uint8 kDefaultPriority = 3;
+static const uint8_t kDefaultPriority = 3;
 // TExport keying material function
-const char kExporterLabel[] = "label";
-const char kExporterContext[] = "context";
-const size_t kExporterContextLen = sizeof(kExporterContext);
+static const char kExporterLabel[] = "label";
+static const char kExporterContext[] = "context";
+static const size_t kExporterContextLen = sizeof(kExporterContext);
 // Identifies QUIC server session
-const QuicServerId kServerId("www.google.com", 443);
+static const QuicServerId kServerId("www.google.com", 443);
 
 // Used by QuicCryptoServerConfig to provide server credentials, returning a
 // canned response equal to |success|.
 class FakeProofSource : public net::ProofSource {
  public:
   explicit FakeProofSource(bool success) : success_(success) {}
 
   // ProofSource override.
-  bool GetProof(const net::IPAddressNumber& server_ip,
+  bool GetProof(const IPAddress& server_ip,
                 const std::string& hostname,
                 const std::string& server_config,
+                net::QuicVersion quic_version,
+                base::StringPiece chlo_hash,
                 bool ecdsa_ok,
-                const std::vector<std::string>** out_certs,
+                scoped_refptr<net::ProofSource::Chain>* out_certs,
                 std::string* out_signature,
                 std::string* out_leaf_cert_sct) override {
     if (success_) {
-      std::vector<std::string>* certs = new std::vector<std::string>();
-      certs->push_back("Required to establish handshake");
-      std::string signature("Signature");
-
-      *out_certs = certs;
-      *out_signature = signature;
+      std::vector<std::string> certs;
+      certs.push_back("Required to establish handshake");
+      *out_certs = new ProofSource::Chain(certs);
+      *out_signature = "Signature";
+      *out_leaf_cert_sct = "Time";
     }
     return success_;
   }
 
  private:
   // Whether or not obtaining proof source succeeds.
   bool success_;
 };
 
 // Used by QuicCryptoClientConfig to verify server credentials, returning a
@@ skipping 23 matching lines @@
 
 // Writes QUIC packets to a fake transport channel that simulates a network.
 class FakeQuicPacketWriter : public QuicPacketWriter {
  public:
   explicit FakeQuicPacketWriter(FakeTransportChannel* fake_channel)
       : fake_channel_(fake_channel) {}
 
   // Sends packets across the network.
   WriteResult WritePacket(const char* buffer,
                           size_t buf_len,
-                          const IPAddressNumber& self_address,
-                          const IPEndPoint& peer_address) override {
+                          const IPAddress& self_address,
+                          const IPEndPoint& peer_address,
+                          PerPacketOptions* options) override {
     rtc::PacketOptions packet_options;
     int rv = fake_channel_->SendPacket(buffer, buf_len, packet_options, 0);
     net::WriteStatus status;
     if (rv > 0) {
       status = net::WRITE_STATUS_OK;
     } else if (fake_channel_->GetError() == EWOULDBLOCK) {
       status = net::WRITE_STATUS_BLOCKED;
     } else {
       status = net::WRITE_STATUS_ERROR;
     }
@@ skipping 17 matching lines @@
   // size of a valid QUIC packet.
   QuicByteCount GetMaxPacketSize(
       const IPEndPoint& peer_address) const override {
     return net::kMaxPacketSize;
   }
 
  private:
   FakeTransportChannel* fake_channel_;
 };
 
-// Creates a FakePacketWriter for a given QuicConnection instance.
-class FakePacketWriterFactory : public QuicConnection::PacketWriterFactory {
- public:
-  explicit FakePacketWriterFactory(FakeTransportChannel* channel)
-      : channel_(channel) {}
-
-  QuicPacketWriter* Create(QuicConnection* connection) const override {
-    return new FakeQuicPacketWriter(channel_);
-  }
-
- private:
-  FakeTransportChannel* channel_;
-};
-
 // Wrapper for QuicSession and transport channel that stores incoming data.
 class QuicSessionForTest : public QuicSession {
  public:
-  QuicSessionForTest(scoped_ptr<net::QuicConnection> connection,
+  QuicSessionForTest(rtc::scoped_ptr<net::QuicConnection> connection,
                      const net::QuicConfig& config,
-                     scoped_ptr<FakeTransportChannel> channel)
+                     rtc::scoped_ptr<FakeTransportChannel> channel)
       : QuicSession(std::move(connection), config),
         channel_(std::move(channel)) {
     channel_->SignalReadPacket.connect(
         this, &QuicSessionForTest::OnChannelReadPacket);
   }
 
   // Called when channel has packets to read.
   void OnChannelReadPacket(TransportChannel* channel,
                            const char* data,
                            size_t size,
@@ skipping 17 matching lines @@
   std::string data() { return last_received_data_; }
 
   bool has_data() { return data().size() > 0; }
 
   FakeTransportChannel* channel() { return channel_.get(); }
 
   ReliableQuicStream* incoming_stream() { return last_incoming_stream_; }
 
  private:
   // Transports QUIC packets to/from peer.
-  scoped_ptr<FakeTransportChannel> channel_;
+  rtc::scoped_ptr<FakeTransportChannel> channel_;
   // Stores data received by peer once it is sent from the other peer.
   std::string last_received_data_;
   // Handles incoming streams from sender.
   ReliableQuicStream* last_incoming_stream_ = nullptr;
 };
 
 // Simulates data transfer between two peers using QUIC.
 class QuicSessionTest : public ::testing::Test,
                         public QuicCryptoClientStream::ProofHandler {
  public:
   QuicSessionTest() : quic_helper_(rtc::Thread::Current()) {}
 
   // Instantiates |client_peer_| and |server_peer_|.
   void CreateClientAndServerSessions();
 
-  scoped_ptr<QuicSessionForTest> CreateSession(
-      scoped_ptr<FakeTransportChannel> channel,
+  rtc::scoped_ptr<QuicSessionForTest> CreateSession(
+      rtc::scoped_ptr<FakeTransportChannel> channel,
       Perspective perspective);
 
   QuicCryptoClientStream* CreateCryptoClientStream(QuicSessionForTest* session,
                                                    bool handshake_success);
   QuicCryptoServerStream* CreateCryptoServerStream(QuicSessionForTest* session,
                                                    bool handshake_success);
 
-  scoped_ptr<QuicConnection> CreateConnection(FakeTransportChannel* channel,
-                                              Perspective perspective);
+  rtc::scoped_ptr<QuicConnection> CreateConnection(
+      FakeTransportChannel* channel,
+      Perspective perspective);
 
   void StartHandshake(bool client_handshake_success,
                       bool server_handshake_success);
 
   // Test handshake establishment and sending/receiving of data.
   void TestStreamConnection(QuicSessionForTest* from_session,
                             QuicSessionForTest* to_session);
   // Test that client and server are not connected after handshake failure.
   void TestDisconnectAfterFailedHandshake();
 
   // QuicCryptoClientStream::ProofHelper overrides.
   void OnProofValid(
       const QuicCryptoClientConfig::CachedState& cached) override {}
   void OnProofVerifyDetailsAvailable(
       const ProofVerifyDetails& verify_details) override {}
 
  protected:
   QuicConnectionHelper quic_helper_;
   QuicConfig config_;
   QuicClock clock_;
 
-  scoped_ptr<QuicSessionForTest> client_peer_;
-  scoped_ptr<QuicSessionForTest> server_peer_;
+  rtc::scoped_ptr<QuicSessionForTest> client_peer_;
+  rtc::scoped_ptr<QuicSessionForTest> server_peer_;
 };
 
 // Initializes "client peer" who begins crypto handshake and "server peer" who
 // establishes encryption with client.
 void QuicSessionTest::CreateClientAndServerSessions() {
-  scoped_ptr<FakeTransportChannel> channel1(
+  rtc::scoped_ptr<FakeTransportChannel> channel1(
       new FakeTransportChannel("channel1", 0));
-  scoped_ptr<FakeTransportChannel> channel2(
+  rtc::scoped_ptr<FakeTransportChannel> channel2(
       new FakeTransportChannel("channel2", 0));
 
   // Prevent channel1->OnReadPacket and channel2->OnReadPacket from calling
   // themselves in a loop, which causes to future packets to be recursively
   // consumed while the current thread blocks consumption of current ones.
   channel2->SetAsync(true);
 
   // Configure peers to send packets to each other.
   channel1->Connect();
   channel2->Connect();
   channel1->SetDestination(channel2.get());
 
   client_peer_ = CreateSession(std::move(channel1), Perspective::IS_CLIENT);
   server_peer_ = CreateSession(std::move(channel2), Perspective::IS_SERVER);
 }
 
-scoped_ptr<QuicSessionForTest> QuicSessionTest::CreateSession(
-    scoped_ptr<FakeTransportChannel> channel,
+rtc::scoped_ptr<QuicSessionForTest> QuicSessionTest::CreateSession(
+    rtc::scoped_ptr<FakeTransportChannel> channel,
     Perspective perspective) {
-  scoped_ptr<QuicConnection> quic_connection =
+  rtc::scoped_ptr<QuicConnection> quic_connection =
       CreateConnection(channel.get(), perspective);
-  return scoped_ptr<QuicSessionForTest>(new QuicSessionForTest(
+  return rtc::scoped_ptr<QuicSessionForTest>(new QuicSessionForTest(
       std::move(quic_connection), config_, std::move(channel)));
 }
 
 QuicCryptoClientStream* QuicSessionTest::CreateCryptoClientStream(
     QuicSessionForTest* session,
     bool handshake_success) {
   QuicCryptoClientConfig* client_config =
       new QuicCryptoClientConfig(new FakeProofVerifier(handshake_success));
   return new QuicCryptoClientStream(
       kServerId, session, new ProofVerifyContext(), client_config, this);
 }
 
 QuicCryptoServerStream* QuicSessionTest::CreateCryptoServerStream(
     QuicSessionForTest* session,
     bool handshake_success) {
   QuicCryptoServerConfig* server_config =
       new QuicCryptoServerConfig("TESTING", QuicRandom::GetInstance(),
                                  new FakeProofSource(handshake_success));
   // Provide server with serialized config string to prove ownership.
   QuicCryptoServerConfig::ConfigOptions options;
   QuicServerConfigProtobuf* primary_config = server_config->GenerateConfig(
       QuicRandom::GetInstance(), &clock_, options);
   server_config->AddConfig(primary_config, clock_.WallNow());
   return new QuicCryptoServerStream(server_config, session);
 }
 
-scoped_ptr<QuicConnection> QuicSessionTest::CreateConnection(
+rtc::scoped_ptr<QuicConnection> QuicSessionTest::CreateConnection(
     FakeTransportChannel* channel,
     Perspective perspective) {
-  FakePacketWriterFactory writer_factory(channel);
+  FakeQuicPacketWriter* writer = new FakeQuicPacketWriter(channel);
 
-  IPAddressNumber ip(net::kIPv4AddressSize, 0);
+  IPAddress ip(0, 0, 0, 0);
   bool owns_writer = true;
 
-  return scoped_ptr<QuicConnection>(new QuicConnection(
-      0, net::IPEndPoint(ip, 0), &quic_helper_, writer_factory, owns_writer,
+  return rtc::scoped_ptr<QuicConnection>(new QuicConnection(
+      0, net::IPEndPoint(ip, 0), &quic_helper_, writer, owns_writer,
       perspective, net::QuicSupportedVersions()));
 }
 
 void QuicSessionTest::StartHandshake(bool client_handshake_success,
                                      bool server_handshake_success) {
   server_peer_->StartServerHandshake(
       CreateCryptoServerStream(server_peer_.get(), server_handshake_success));
   client_peer_->StartClientHandshake(
       CreateCryptoClientStream(client_peer_.get(), client_handshake_success));
 }
@@ skipping 94 matching lines @@
   StartHandshake(true, false);
   TestDisconnectAfterFailedHandshake();
 }
 
 // Test that data streams are not created before handshake.
 TEST_F(QuicSessionTest, CannotCreateDataStreamBeforeHandshake) {
   CreateClientAndServerSessions();
   EXPECT_EQ(nullptr, server_peer_->CreateOutgoingDynamicStream(5));
   EXPECT_EQ(nullptr, client_peer_->CreateOutgoingDynamicStream(5));
 }