Remove WVoE::SetAudioDeviceModule() - it is now set in ctor.

- Add temporary VoEBase::audio_device_module() method.
- Remove WVoE::SetAudioDeviceModule() - the ADM is now supplied in ctor.
- Remove WVoE::Init() and WVoE::Terminate().
- Remove MediaEngineInterface::Terminate().

BUG=webrtc:4690
Committed: https://crrev.com/ff97631e3c7460c97909d67b5ff171003cb968eb
Cr-Commit-Position: refs/heads/master@{#12173}

[the sun, 2016-03-24 17:34:57]

Description was changed from

==========
Remove WVoE::SetAudioDeviceModule() - it is now set in ctor.

BUG=webrtc:4690
==========

to

==========
Remove WVoE::SetAudioDeviceModule() - The ADM is now supplied in ctor.

BUG=webrtc:4690
==========

[the sun, 2016-03-24 19:36:44]

Description was changed from

==========
Remove WVoE::SetAudioDeviceModule() - The ADM is now supplied in ctor.

BUG=webrtc:4690
==========

to

==========
- Add temporary VoEBase::audio_device_module() method.
- Remove WVoE::SetAudioDeviceModule() - the ADM is now supplied in ctor.

BUG=webrtc:4690
==========

[the sun, 2016-03-24 19:36:44]

solenberg@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[pthatcher1, 2016-03-25 23:23:22]

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:538: adm_->AddRef();
Should we use a scoped_refptr for adm_?

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/voice_engine/inclu...
File webrtc/voice_engine/include/voe_base.h (right):

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/voice_engine/inclu...
webrtc/voice_engine/include/voe_base.h:137: virtual AudioDeviceModule*
audio_device_module() = 0;
Why are we adding a method that shouldn't be used?

Do we plan to make it permanent?  If it's temporary, when do we plan to remove
it?  If it's only supposed to be used for X, what is X?

[Taylor Brandstetter, 2016-03-29 00:49:23]

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (left):

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:552: voe_wrapper_.reset();
Is there a reason this was called here, and if so, why is it no longer
necessary?

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:538: adm_->AddRef();
On 2016/03/25 23:23:21, pthatcher1 wrote:
> Should we use a scoped_refptr for adm_?

+1

[the sun, 2016-03-29 14:20:57]

Description was changed from

==========
- Add temporary VoEBase::audio_device_module() method.
- Remove WVoE::SetAudioDeviceModule() - the ADM is now supplied in ctor.

BUG=webrtc:4690
==========

to

==========
- Add temporary VoEBase::audio_device_module() method.
- Remove WVoE::SetAudioDeviceModule() - the ADM is now supplied in ctor.
- Remove WVoE::Init() and WVoE::Terminate().
- Remove MediaEngineInterface::Terminate().

BUG=webrtc:4690
==========

[the sun, 2016-03-29 21:46:40]

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (left):

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:552: voe_wrapper_.reset();
On 2016/03/29 00:49:23, Taylor Brandstetter wrote:
> Is there a reason this was called here, and if so, why is it no longer
> necessary?

Looks like it wasn't needed; VoE's ADM reference should already have been
released from VoEBaseImpl::TerminateInternal() [called indirectly from
WVoE::Terminate()]. Note that previously adm_ would only be set if using an
external ADM. I've added a unit test to verify ref counting of the ADM is well
behaved.

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvoiceengine.cc (right):

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:538: adm_->AddRef();
On 2016/03/29 00:49:23, Taylor Brandstetter wrote:
> On 2016/03/25 23:23:21, pthatcher1 wrote:
> > Should we use a scoped_refptr for adm_?
> 
> +1

Done.

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvoiceengine.cc:538: adm_->AddRef();
On 2016/03/29 00:49:23, Taylor Brandstetter wrote:
> On 2016/03/25 23:23:21, pthatcher1 wrote:
> > Should we use a scoped_refptr for adm_?
> 
> +1

Done.

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/voice_engine/inclu...
File webrtc/voice_engine/include/voe_base.h (right):

https://codereview.webrtc.org/1830213002/diff/40001/webrtc/voice_engine/inclu...
webrtc/voice_engine/include/voe_base.h:137: virtual AudioDeviceModule*
audio_device_module() = 0;
On 2016/03/25 23:23:22, pthatcher1 wrote:
> Why are we adding a method that shouldn't be used?
> 
> Do we plan to make it permanent?  If it's temporary, when do we plan to remove
> it?  If it's only supposed to be used for X, what is X?

All the legacy VoE interfaces are going away. This is a temporary measure and we
don't want any 3rd parties start using it.

[pthatcher1, 2016-03-30 16:37:55]

lgtm

[Taylor Brandstetter, 2016-03-30 20:34:41]

lgtm

[the sun, 2016-03-30 20:37:48]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-03-30 20:37:49]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1830213002/#ps100001 (title:
"rebase")

[commit-bot: I haz the power, 2016-03-30 20:38:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830213002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830213002/100001

[commit-bot: I haz the power, 2016-03-30 22:38:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 22:38:30]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2016-03-31 05:48:48]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2016-03-31 05:48:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830213002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830213002/100001

[commit-bot: I haz the power, 2016-03-31 06:28:55]

Description was changed from

==========
- Add temporary VoEBase::audio_device_module() method.
- Remove WVoE::SetAudioDeviceModule() - the ADM is now supplied in ctor.
- Remove WVoE::Init() and WVoE::Terminate().
- Remove MediaEngineInterface::Terminate().

BUG=webrtc:4690
==========

to

==========
- Add temporary VoEBase::audio_device_module() method.
- Remove WVoE::SetAudioDeviceModule() - the ADM is now supplied in ctor.
- Remove WVoE::Init() and WVoE::Terminate().
- Remove MediaEngineInterface::Terminate().

BUG=webrtc:4690
==========

[commit-bot: I haz the power, 2016-03-31 06:28:56]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-31 06:29:02]

Description was changed from

==========
- Add temporary VoEBase::audio_device_module() method.
- Remove WVoE::SetAudioDeviceModule() - the ADM is now supplied in ctor.
- Remove WVoE::Init() and WVoE::Terminate().
- Remove MediaEngineInterface::Terminate().

BUG=webrtc:4690
==========

to

==========
- Add temporary VoEBase::audio_device_module() method.
- Remove WVoE::SetAudioDeviceModule() - the ADM is now supplied in ctor.
- Remove WVoE::Init() and WVoE::Terminate().
- Remove MediaEngineInterface::Terminate().

BUG=webrtc:4690

Committed: https://crrev.com/ff97631e3c7460c97909d67b5ff171003cb968eb
Cr-Commit-Position: refs/heads/master@{#12173}
==========

[commit-bot: I haz the power, 2016-03-31 06:29:03]

Patchset 6 (id:??) landed as
https://crrev.com/ff97631e3c7460c97909d67b5ff171003cb968eb
Cr-Commit-Position: refs/heads/master@{#12173}