Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1844843003: Add mock AudioDeviceModule. (Closed)

Created:
4 years, 8 months ago by the sun
Modified:
4 years, 8 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@wvoe_adm_in_ctor
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add mock AudioDeviceModule. BUG=webrtc:4690 Committed: https://crrev.com/bc37fc8418da951cf56f5580731b8b034d1f12a6 Cr-Commit-Position: refs/heads/master@{#12220}

Patch Set 1 #

Patch Set 2 : Add a mock for AudioDeviceModule and use that in the WVoE unittests. #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -133 lines) Patch
M webrtc/media/engine/fakewebrtcvideoengine.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 7 chunks +41 lines, -109 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 13 chunks +34 lines, -21 lines 0 comments Download
M webrtc/media/media.gyp View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
A webrtc/modules/audio_device/include/mock_audio_device.h View 1 chunk +135 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
the sun
4 years, 8 months ago (2016-03-31 15:02:17 UTC) #2
the sun
On 2016/03/31 15:02:17, the sun wrote: henrika@, hold yer horses, looks like I messed up ...
4 years, 8 months ago (2016-03-31 15:18:37 UTC) #3
the sun
On 2016/03/31 15:18:37, the sun wrote: > On 2016/03/31 15:02:17, the sun wrote: > > ...
4 years, 8 months ago (2016-03-31 15:40:50 UTC) #5
the sun
Switching to a Henrik who is not OOO. :)
4 years, 8 months ago (2016-04-01 07:45:59 UTC) #7
henrika_webrtc
Nice work. LGTM. And yes, I am back :-)
4 years, 8 months ago (2016-04-04 13:44:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844843003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844843003/80001
4 years, 8 months ago (2016-04-04 14:32:45 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 8 months ago (2016-04-04 16:54:49 UTC) #15
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/bc37fc8418da951cf56f5580731b8b034d1f12a6 Cr-Commit-Position: refs/heads/master@{#12220}
4 years, 8 months ago (2016-04-04 16:55:00 UTC) #17
Henrik Grunell WebRTC
4 years, 8 months ago (2016-04-05 09:20:10 UTC) #18
Message was sent while issue was closed.
On 2016/04/01 07:45:59, the sun wrote:
> Switching to a Henrik who is not OOO. :)

Oh, the irony. I was too ooo on Friday. Then Henrik A was back yesterday...

Powered by Google App Engine
This is Rietveld 408576698