Build dynamic framework with podspec for Objective-C API.

Build dynamic framework with podspec for Objective-C API.

BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/3a2f7e01ef14b351ecb3f681eed6b4591dd15ca0
Patch from Jon Hjelle <hjon@webrtc.org>;.

Cr-Commit-Position: refs/heads/master@{#12128}

[hjon_webrtc, 2016-03-23 17:31:59]

hjon@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[hjon_webrtc, 2016-03-23 17:32:00]

This is still in a bit of draft state, but it does build a framework that can be
used by the PodTest project.

If you could at least give it a glance to check for any glaring issues, I'd
appreciate it. I need to add a README, clean up some the style of the PodTest
source files, and I expect we may change some names and/or output directories.

[tkchin_webrtc, 2016-03-23 17:52:56]

Overall looks good! Excited that this is happening.

Consider moving directory to
webrtc/build/ios/SDK/Framework/WebRTC.pbxproj

Also, please add a README file for how the xcodeproj was created. (ie what steps
were necessary - finding the right compile flags, generating the static libs,
etc).

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
File webrtc/build/ios/build_ios_framework.sh (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
webrtc/build/ios/build_ios_framework.sh:36: ${BUILD_WEBRTC_SCRIPT}
check for return code and exit if failure

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
webrtc/build/ios/build_ios_framework.sh:39: ${FLATTEN_HEADERS_SCRIPT}
ditto

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
webrtc/build/ios/build_ios_framework.sh:42: sed -E -i ''
's/"webrtc\/(api|base)\/objc\/(.*)"/<WebRTC\/\2>/g'
out_ios_framework/include/*.h
This will be hard to maintain as we include more files.
Have a multiline sed instead
e.g. 
SED_PATTERN = "
  s/foo/bar/g;
  s/bar/baz/g;
"

sed ...

Also, to be conservative I would match on the $#import as well

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
webrtc/build/ios/build_ios_framework.sh:47: xcodebuild -project WebRTC.xcodeproj
-scheme WebRTC -destination 'platform=iOS Simulator,name=iPhone 6'
-configuration Release build
nit: same order of arguments
Do these build both architectures (the first one is armv7/arm64, the second
i386/x86_64)?

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
webrtc/build/ios/build_ios_framework.sh:55: rm -R
out_ios_framework/WebRTC.framework/_CodeSignature
Does this work? Is code signature just that directory?

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
File webrtc/build/ios/webrtc/PodTest/PodTest/AppDelegate.h (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
webrtc/build/ios/webrtc/PodTest/PodTest/AppDelegate.h:2: //  AppDelegate.h
Update header to WebRTC

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
File webrtc/build/ios/webrtc/PodTest/PodTest/AppDelegate.m (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
webrtc/build/ios/webrtc/PodTest/PodTest/AppDelegate.m:3: //  PodTest
ditto header. Cleanup file by removing unused methods + comments.

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
File webrtc/build/ios/webrtc/PodTest/PodTest/ViewController.h (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
webrtc/build/ios/webrtc/PodTest/PodTest/ViewController.h:2: //  ViewController.h
ditto copyright header

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
File webrtc/build/ios/webrtc/PodTest/PodTest/ViewController.m (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
webrtc/build/ios/webrtc/PodTest/PodTest/ViewController.m:2: //  ViewController.m
ditto header + cleanup

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/WebRT...
File webrtc/build/ios/webrtc/WebRTC/WebRTC.xcodeproj/project.pbxproj (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/WebRT...
webrtc/build/ios/webrtc/WebRTC/WebRTC.xcodeproj/project.pbxproj:769:
COPY_PHASE_STRIP = NO;
we should strip, and generate a dSYM file.

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/WebRT...
File webrtc/build/ios/webrtc/WebRTC/WebRTC/WebRTC.h (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/WebRT...
webrtc/build/ios/webrtc/WebRTC/WebRTC/WebRTC.h:19: // In this header, you should
import all the public headers of your framework using statements like #import
<WebRTC/PublicHeader.h>
cleanup

[hjon_webrtc, 2016-03-25 00:09:47]

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
File webrtc/build/ios/build_ios_framework.sh (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
webrtc/build/ios/build_ios_framework.sh:36: ${BUILD_WEBRTC_SCRIPT}
On 2016/03/23 17:52:55, tkchin_webrtc wrote:
> check for return code and exit if failure

Done.

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
webrtc/build/ios/build_ios_framework.sh:39: ${FLATTEN_HEADERS_SCRIPT}
On 2016/03/23 17:52:55, tkchin_webrtc wrote:
> ditto

Done.

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
webrtc/build/ios/build_ios_framework.sh:42: sed -E -i ''
's/"webrtc\/(api|base)\/objc\/(.*)"/<WebRTC\/\2>/g'
out_ios_framework/include/*.h
On 2016/03/23 17:52:55, tkchin_webrtc wrote:
> This will be hard to maintain as we include more files.
> Have a multiline sed instead
> e.g. 
> SED_PATTERN = "
>   s/foo/bar/g;
>   s/bar/baz/g;
> "
> 
> sed ...
> 
> Also, to be conservative I would match on the $#import as well

Done.

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
webrtc/build/ios/build_ios_framework.sh:47: xcodebuild -project WebRTC.xcodeproj
-scheme WebRTC -destination 'platform=iOS Simulator,name=iPhone 6'
-configuration Release build
On 2016/03/23 17:52:56, tkchin_webrtc wrote:
> nit: same order of arguments
> Do these build both architectures (the first one is armv7/arm64, the second
> i386/x86_64)?

Done. Correct, the first builds armv7/arm64 and the second builds i386/x86_64. I
had hoped there would be a more convenient way to build the Simulator
architectures without specifying the name of the simulated device, but wasn't
able to find anything. As an example, there's a "generic/" specifier that can be
used, but it didn't seem to work for the Simulator builds, so it seems that's
only for physical device builds). There's also an -sdk flag, but xcodebuild
doesn't infer the destination from that (http://www.openradar.me/23973685).

It's unfortunate because I'd like to use something more future-proof than a
device name that will eventually have to change. :-/

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/build_ios_fr...
webrtc/build/ios/build_ios_framework.sh:55: rm -R
out_ios_framework/WebRTC.framework/_CodeSignature
On 2016/03/23 17:52:56, tkchin_webrtc wrote:
> Does this work? Is code signature just that directory?

From everything I've tested so far, it does seem to just be that directory and
removing it seems to be sufficient and work.

Edit: The above did seem to be true, but I found a way to simply not codesign
with xcodebuild, which seems to be a factor in achieving reproducible builds.

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
File webrtc/build/ios/webrtc/PodTest/PodTest/AppDelegate.h (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
webrtc/build/ios/webrtc/PodTest/PodTest/AppDelegate.h:2: //  AppDelegate.h
On 2016/03/23 17:52:56, tkchin_webrtc wrote:
> Update header to WebRTC

Done.

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
File webrtc/build/ios/webrtc/PodTest/PodTest/AppDelegate.m (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
webrtc/build/ios/webrtc/PodTest/PodTest/AppDelegate.m:3: //  PodTest
On 2016/03/23 17:52:56, tkchin_webrtc wrote:
> ditto header. Cleanup file by removing unused methods + comments.

Done.

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
File webrtc/build/ios/webrtc/PodTest/PodTest/ViewController.h (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
webrtc/build/ios/webrtc/PodTest/PodTest/ViewController.h:2: //  ViewController.h
On 2016/03/23 17:52:56, tkchin_webrtc wrote:
> ditto copyright header

Done.

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
File webrtc/build/ios/webrtc/PodTest/PodTest/ViewController.m (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/PodTe...
webrtc/build/ios/webrtc/PodTest/PodTest/ViewController.m:2: //  ViewController.m
On 2016/03/23 17:52:56, tkchin_webrtc wrote:
> ditto header + cleanup

Done.

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/WebRT...
File webrtc/build/ios/webrtc/WebRTC/WebRTC.xcodeproj/project.pbxproj (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/WebRT...
webrtc/build/ios/webrtc/WebRTC/WebRTC.xcodeproj/project.pbxproj:769:
COPY_PHASE_STRIP = NO;
On 2016/03/23 17:52:56, tkchin_webrtc wrote:
> we should strip, and generate a dSYM file.

Looks like "Yes" is the iOS Default for STRIP_INSTALLED_PRODUCT. I presume
that's why it's not showing up, since setting it to "Yes" at a lower level (such
as the WebRTC project or target) still doesn't populate the project file. I did
set DEPLOYMENT_POSTPROCESSING to "Yes" which appears to result in reproducible
builds (along with not code signing, which seems to be allowed via xcodebuild
for a framework, though not within Xcode itself).

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/WebRT...
File webrtc/build/ios/webrtc/WebRTC/WebRTC/WebRTC.h (right):

https://codereview.webrtc.org/1829783003/diff/1/webrtc/build/ios/webrtc/WebRT...
webrtc/build/ios/webrtc/WebRTC/WebRTC/WebRTC.h:19: // In this header, you should
import all the public headers of your framework using statements like #import
<WebRTC/PublicHeader.h>
On 2016/03/23 17:52:56, tkchin_webrtc wrote:
> cleanup

Done.

[tkchin_webrtc, 2016-03-25 17:46:07]

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/PodT...
File webrtc/build/ios/SDK/PodTest/PodTest/AppDelegate.m (right):

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/PodT...
webrtc/build/ios/SDK/PodTest/PodTest/AppDelegate.m:16: -
(BOOL)application:(UIApplication *)application
didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
100 char

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/PodT...
File webrtc/build/ios/SDK/PodTest/PodTest/main.m (right):

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/PodT...
webrtc/build/ios/SDK/PodTest/PodTest/main.m:14: int main(int argc, char *
argv[]) {
char*?

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/README
File webrtc/build/ios/SDK/README (right):

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/READ...
webrtc/build/ios/SDK/README:1: We want to generate a dynamic framework for a
CocoaPod. Unfortunately, using gyp-xcode generation for a framework currently
presents some issues. To get around those issues, we chose to create a project
with Xcode for building the framework directly.
100 char? Thanks :)

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/READ...
webrtc/build/ios/SDK/README:1: We want to generate a dynamic framework for a
CocoaPod. Unfortunately, using gyp-xcode generation for a framework currently
presents some issues. To get around those issues, we chose to create a project
with Xcode for building the framework directly.
Do we need to say anything about stripping simulator slices before app store
submission, or do pods do that now?

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/READ...
webrtc/build/ios/SDK/README:19: The minimum number of system frameworks were
linked against based on build errors (currently AVFoundation, AudioToolbox,
CoreMedia, VideoToolbox).
I think we may need these as well:
CFNetwork, CoreGraphics, CoreVideo, GLKit, OpenGLES, QuartzCore

Unless they are covered by CoreMedia?

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/READ...
webrtc/build/ios/SDK/README:25: DEPLOYMENT_POSTPROCESSING is set to "Yes" so
debug symbols will be stripped (the iOS Default for STRIP_INSTALLED_PRODUCT is
already set to "Yes").
Can you mention something about dSYM generation?

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/WebR...
File webrtc/build/ios/SDK/WebRTC.podspec (right):

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/WebR...
webrtc/build/ios/SDK/WebRTC.podspec:20: #.frameworks = "AVFoundation",
"AudioToolbox", "CoreMedia", "GLKit", "VideoToolbox"
I don't really now pod syntax but are these commented out?

[hjon_webrtc, 2016-03-25 21:17:44]

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/PodT...
File webrtc/build/ios/SDK/PodTest/PodTest/AppDelegate.m (right):

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/PodT...
webrtc/build/ios/SDK/PodTest/PodTest/AppDelegate.m:16: -
(BOOL)application:(UIApplication *)application
didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
On 2016/03/25 17:46:07, tkchin_webrtc wrote:
> 100 char

Done.

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/PodT...
File webrtc/build/ios/SDK/PodTest/PodTest/main.m (right):

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/PodT...
webrtc/build/ios/SDK/PodTest/PodTest/main.m:14: int main(int argc, char *
argv[]) {
On 2016/03/25 17:46:07, tkchin_webrtc wrote:
> char*?

Done.

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/README
File webrtc/build/ios/SDK/README (right):

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/READ...
webrtc/build/ios/SDK/README:1: We want to generate a dynamic framework for a
CocoaPod. Unfortunately, using gyp-xcode generation for a framework currently
presents some issues. To get around those issues, we chose to create a project
with Xcode for building the framework directly.
On 2016/03/25 17:46:07, tkchin_webrtc wrote:
> Do we need to say anything about stripping simulator slices before app store
> submission, or do pods do that now?

As far as I can tell, CocoaPods takes care of that for us.

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/READ...
webrtc/build/ios/SDK/README:19: The minimum number of system frameworks were
linked against based on build errors (currently AVFoundation, AudioToolbox,
CoreMedia, VideoToolbox).
On 2016/03/25 17:46:07, tkchin_webrtc wrote:
> I think we may need these as well:
> CFNetwork, CoreGraphics, CoreVideo, GLKit, OpenGLES, QuartzCore
> 
> Unless they are covered by CoreMedia?

They don't appear to be covered by CoreMedia, but the four I listed were the
only ones I received linker errors for. I didn't try yet, but it's possible it
has something to do with the default for CLANG_MODULES_AUTOLINK (default being
"Yes").

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/READ...
webrtc/build/ios/SDK/README:25: DEPLOYMENT_POSTPROCESSING is set to "Yes" so
debug symbols will be stripped (the iOS Default for STRIP_INSTALLED_PRODUCT is
already set to "Yes").
On 2016/03/25 17:46:07, tkchin_webrtc wrote:
> Can you mention something about dSYM generation?

Done.

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/WebR...
File webrtc/build/ios/SDK/WebRTC.podspec (right):

https://codereview.webrtc.org/1829783003/diff/20001/webrtc/build/ios/SDK/WebR...
webrtc/build/ios/SDK/WebRTC.podspec:20: #.frameworks = "AVFoundation",
"AudioToolbox", "CoreMedia", "GLKit", "VideoToolbox"
On 2016/03/25 17:46:07, tkchin_webrtc wrote:
> I don't really now pod syntax but are these commented out?

Yes; I've removed them since we don't seem to need them for the framework.

[tkchin_webrtc, 2016-03-25 21:26:20]

lgtm

[commit-bot: I haz the power, 2016-03-25 21:49:26]

Description was changed from

==========
Build dynamic framework with podspec for Objective-C API.

BUG=
==========

to

==========
Build dynamic framework with podspec for Objective-C API.

BUG=
R=tkchin@webrtc.org

Committed: https://crrev.com/3a2f7e01ef14b351ecb3f681eed6b4591dd15ca0
Patch from Jon Hjelle <hjon@webrtc.org>.

Cr-Commit-Position: refs/heads/master@{#12128}
==========

[commit-bot: I haz the power, 2016-03-25 21:49:27]

Patchset 5 (id:??) landed as
https://crrev.com/3a2f7e01ef14b351ecb3f681eed6b4591dd15ca0
Cr-Commit-Position: refs/heads/master@{#12128}