Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1824573002: Fix some warnings in ObjC code. (Closed)

Created:
4 years, 9 months ago by tkchin_webrtc
Modified:
4 years, 9 months ago
Reviewers:
hjon_webrtc, Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix some warnings in ObjC code. BUG= Committed: https://crrev.com/121ac122b99cb3df084b5bd4132ec7c0dcc3045f Cr-Commit-Position: refs/heads/master@{#12076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M webrtc/api/objc/RTCDataChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/objc/RTCDataChannel.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/objc/RTCIceCandidate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/objc/RTCIceCandidate.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/api/objc/RTCOpenGLVideoRenderer.mm View 6 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tkchin_webrtc
4 years, 9 months ago (2016-03-21 04:45:47 UTC) #3
hjon_webrtc
On 2016/03/21 04:45:47, tkchin_webrtc wrote: lgtm
4 years, 9 months ago (2016-03-21 15:45:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824573002/1
4 years, 9 months ago (2016-03-21 16:07:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 16:08:43 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 16:08:56 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/121ac122b99cb3df084b5bd4132ec7c0dcc3045f
Cr-Commit-Position: refs/heads/master@{#12076}

Powered by Google App Engine
This is Rietveld 408576698