Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Side by Side Diff: webrtc/api/objc/RTCIceCandidate.mm

Issue 1824573002: Fix some warnings in ObjC code. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/objc/RTCIceCandidate.h ('k') | webrtc/api/objc/RTCOpenGLVideoRenderer.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import "RTCIceCandidate.h" 11 #import "RTCIceCandidate.h"
12 12
13 #import "webrtc/api/objc/RTCIceCandidate+Private.h" 13 #import "webrtc/api/objc/RTCIceCandidate+Private.h"
14 #import "webrtc/base/objc/NSString+StdString.h" 14 #import "webrtc/base/objc/NSString+StdString.h"
15 #import "webrtc/base/objc/RTCLogging.h" 15 #import "webrtc/base/objc/RTCLogging.h"
16 16
17 @implementation RTCIceCandidate 17 @implementation RTCIceCandidate
18 18
19 @synthesize sdpMid = _sdpMid; 19 @synthesize sdpMid = _sdpMid;
20 @synthesize sdpMLineIndex = _sdpMLineIndex; 20 @synthesize sdpMLineIndex = _sdpMLineIndex;
21 @synthesize sdp = _sdp; 21 @synthesize sdp = _sdp;
22 22
23 - (instancetype)initWithSdp:(NSString *)sdp 23 - (instancetype)initWithSdp:(NSString *)sdp
24 sdpMLineIndex:(NSInteger)sdpMLineIndex 24 sdpMLineIndex:(int)sdpMLineIndex
25 sdpMid:(NSString *)sdpMid { 25 sdpMid:(NSString *)sdpMid {
26 NSParameterAssert(sdp.length); 26 NSParameterAssert(sdp.length);
27 if (self = [super init]) { 27 if (self = [super init]) {
28 _sdpMid = [sdpMid copy]; 28 _sdpMid = [sdpMid copy];
29 _sdpMLineIndex = sdpMLineIndex; 29 _sdpMLineIndex = sdpMLineIndex;
30 _sdp = [sdp copy]; 30 _sdp = [sdp copy];
31 } 31 }
32 return self; 32 return self;
33 } 33 }
34 34
35 - (NSString *)description { 35 - (NSString *)description {
36 return [NSString stringWithFormat:@"RTCIceCandidate:\n%@\n%ld\n%@", 36 return [NSString stringWithFormat:@"RTCIceCandidate:\n%@\n%d\n%@",
37 _sdpMid, 37 _sdpMid,
38 (long)_sdpMLineIndex, 38 _sdpMLineIndex,
39 _sdp]; 39 _sdp];
40 } 40 }
41 41
42 #pragma mark - Private 42 #pragma mark - Private
43 43
44 - (instancetype)initWithNativeCandidate: 44 - (instancetype)initWithNativeCandidate:
45 (const webrtc::IceCandidateInterface *)candidate { 45 (const webrtc::IceCandidateInterface *)candidate {
46 NSParameterAssert(candidate); 46 NSParameterAssert(candidate);
47 std::string sdp; 47 std::string sdp;
48 candidate->ToString(&sdp); 48 candidate->ToString(&sdp);
(...skipping 12 matching lines...) Expand all
61 if (!candidate) { 61 if (!candidate) {
62 RTCLog(@"Failed to create ICE candidate: %s\nline: %s", 62 RTCLog(@"Failed to create ICE candidate: %s\nline: %s",
63 error.description.c_str(), 63 error.description.c_str(),
64 error.line.c_str()); 64 error.line.c_str());
65 } 65 }
66 66
67 return rtc::scoped_ptr<webrtc::IceCandidateInterface>(candidate); 67 return rtc::scoped_ptr<webrtc::IceCandidateInterface>(candidate);
68 } 68 }
69 69
70 @end 70 @end
OLDNEW
« no previous file with comments | « webrtc/api/objc/RTCIceCandidate.h ('k') | webrtc/api/objc/RTCOpenGLVideoRenderer.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698