Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 1824083002: Make Android min-resolution rotation-agnostic. (Closed)

Created:
4 years, 9 months ago by pbos-webrtc
Modified:
4 years, 9 months ago
Reviewers:
AlexG, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make Android min-resolution rotation-agnostic. Min resolution shouldn't have anything to do with CVO being enabled or not, nor device rotation. BUG=webrtc:5678 R=glaznev@webrtc.org TBR=stefan@webrtc.org Committed: https://crrev.com/01bcbd0df647dff61c4e209444e5cc5f5b6dddc1 Cr-Commit-Position: refs/heads/master@{#12092}

Patch Set 1 #

Patch Set 2 : some fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -18 lines) Patch
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.cc View 1 5 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
pbos-webrtc
PTAL, this is necessary to downscale to QVGA when input is not landscape.
4 years, 9 months ago (2016-03-22 18:46:13 UTC) #1
AlexG
On 2016/03/22 18:46:13, pbos-webrtc wrote: > PTAL, this is necessary to downscale to QVGA when ...
4 years, 9 months ago (2016-03-22 18:50:04 UTC) #2
pbos-webrtc
some fixes
4 years, 9 months ago (2016-03-22 19:08:29 UTC) #3
pbos-webrtc
PTAL, this added some refactoring as well.
4 years, 9 months ago (2016-03-22 19:09:08 UTC) #4
AlexG
On 2016/03/22 19:09:08, pbos-webrtc wrote: > PTAL, this added some refactoring as well. lgtm
4 years, 9 months ago (2016-03-22 20:39:35 UTC) #5
pbos-webrtc
+tbr stefan@ for the quality_scaler changes.
4 years, 9 months ago (2016-03-22 20:44:24 UTC) #8
pbos-webrtc
Committed patchset #2 (id:20001) manually as 01bcbd0df647dff61c4e209444e5cc5f5b6dddc1 (presubmit successful).
4 years, 9 months ago (2016-03-22 20:44:48 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 20:44:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01bcbd0df647dff61c4e209444e5cc5f5b6dddc1
Cr-Commit-Position: refs/heads/master@{#12092}

Powered by Google App Engine
This is Rietveld 408576698