Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: webrtc/modules/video_coding/utility/quality_scaler.cc

Issue 1824083002: Make Android min-resolution rotation-agnostic. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: some fixes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/utility/quality_scaler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/utility/quality_scaler.cc
diff --git a/webrtc/modules/video_coding/utility/quality_scaler.cc b/webrtc/modules/video_coding/utility/quality_scaler.cc
index a46e8502cb310e459c77a97f0fd0b4ab6264b86e..68ae9218ea2162d1c39c6a47005d5c3f779e8b95 100644
--- a/webrtc/modules/video_coding/utility/quality_scaler.cc
+++ b/webrtc/modules/video_coding/utility/quality_scaler.cc
@@ -40,6 +40,9 @@ void QualityScaler::Init(int low_qp_threshold,
low_qp_threshold_ = low_qp_threshold;
high_qp_threshold_ = high_qp_threshold;
use_framerate_reduction_ = use_framerate_reduction;
+ downscale_shift_ = 0;
+ const int init_width = width;
+ const int init_height = height;
// TODO(glaznev): Investigate using thresholds for other resolutions
// or threshold tables.
if (initial_bitrate_kbps > 0 &&
@@ -51,8 +54,7 @@ void QualityScaler::Init(int low_qp_threshold,
height /= 2;
}
}
- res_.width = width;
- res_.height = height;
+ UpdateTargetResolution(init_width, init_height);
target_framerate_ = -1;
}
@@ -81,8 +83,6 @@ void QualityScaler::OnEncodeFrame(const VideoFrame& frame) {
// Should be set through InitEncode -> Should be set by now.
assert(low_qp_threshold_ >= 0);
assert(num_samples_ > 0);
- res_.width = frame.width();
- res_.height = frame.height();
// Update scale factor.
int avg_drop = 0;
@@ -117,15 +117,7 @@ void QualityScaler::OnEncodeFrame(const VideoFrame& frame) {
AdjustScale(true);
}
}
-
- assert(downscale_shift_ >= 0);
- for (int shift = downscale_shift_;
- shift > 0 && (res_.width / 2 >= min_width_) &&
- (res_.height / 2 >= min_height_);
- --shift) {
- res_.width /= 2;
- res_.height /= 2;
- }
+ UpdateTargetResolution(frame.width(), frame.height());
}
QualityScaler::Resolution QualityScaler::GetScaledResolution() const {
@@ -153,6 +145,19 @@ const VideoFrame& QualityScaler::GetScaledFrame(const VideoFrame& frame) {
return scaled_frame_;
}
+void QualityScaler::UpdateTargetResolution(int frame_width, int frame_height) {
+ assert(downscale_shift_ >= 0);
+ res_.width = frame_width;
+ res_.height = frame_height;
+ for (int shift = downscale_shift_;
+ shift > 0 && (res_.width / 2 >= min_width_) &&
+ (res_.height / 2 >= min_height_);
+ --shift) {
+ res_.width /= 2;
+ res_.height /= 2;
+ }
+}
+
void QualityScaler::ClearSamples() {
framedrop_percent_.Reset();
average_qp_.Reset();
« no previous file with comments | « webrtc/modules/video_coding/utility/quality_scaler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698