webrtc/api/webrtcsession_unittest.cc - Issue 1823503002: Reland Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/webrtcsession_unittest.cc

Issue 1823503002: Reland Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/webrtcsession_unittest.cc

diff --git a/webrtc/api/webrtcsession_unittest.cc b/webrtc/api/webrtcsession_unittest.cc

index 77c4854680bf141d2c1ae194f74ee0ad1b59edb2..18c1a95116e5e812c0f784137c5fb28a463e895c 100644

--- a/webrtc/api/webrtcsession_unittest.cc

+++ b/webrtc/api/webrtcsession_unittest.cc

@@ -4054,7 +4054,7 @@ TEST_P(WebRtcSessionTest, TestSctpDataChannelOpenMessage) {

webrtc::DataChannelInit config;

config.id = 1;

- rtc::Buffer payload;

+ rtc::CopyOnWriteBuffer payload;

webrtc::WriteDataChannelOpenMessage("a", config, &payload);

cricket::ReceiveDataParams params;

params.ssrc = config.id;

« no previous file with comments | « webrtc/api/webrtcsession.cc ('k') | webrtc/base/buffer.h » ('j') | webrtc/media/sctp/sctpdataengine.cc » ('J')