Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: webrtc/base/buffer.h

Issue 1823503002: Reland Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/buffer.h
diff --git a/webrtc/base/buffer.h b/webrtc/base/buffer.h
index 681348d91048a16c8122339c41a1315e18528a0a..f007929a2943f053ffe4bc9a3349c5f708b71c69 100644
--- a/webrtc/base/buffer.h
+++ b/webrtc/base/buffer.h
@@ -49,7 +49,6 @@ struct ByteType {
class Buffer {
public:
Buffer(); // An empty buffer.
- Buffer(const Buffer& buf); // Copy size and contents of an existing buffer.
Buffer(Buffer&& buf); // Move contents from an existing buffer.
// Construct a buffer with the specified number of uninitialized bytes.
@@ -99,12 +98,6 @@ class Buffer {
return capacity_;
}
- Buffer& operator=(const Buffer& buf) {
- if (&buf != this)
- SetData(buf.data(), buf.size());
- return *this;
- }
-
Buffer& operator=(Buffer&& buf) {
RTC_DCHECK(IsConsistent());
RTC_DCHECK(buf.IsConsistent());
@@ -270,6 +263,8 @@ class Buffer {
size_t size_;
size_t capacity_;
std::unique_ptr<uint8_t[]> data_;
+
+ RTC_DISALLOW_COPY_AND_ASSIGN(Buffer);
};
} // namespace rtc

Powered by Google App Engine
This is Rietveld 408576698