Reland Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies.

Reland Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies.

This CL removes copy and assign support from Buffer and changes various
parameters from Buffer to CopyOnWriteBuffer so they can be passed along
and copied without actually copying the underlying data.

With this changed some parameters to be "const" and fixed an issue when
creating a CopyOnWriteBuffer with empty data.

BUG=webrtc:5155
Committed: https://crrev.com/eec21bdae34bd63ebf568430488d6e25d8db9b4a
Cr-Commit-Position: refs/heads/master@{#12062}

[joachim, 2016-03-20 10:14:09]

jbauch@webrtc.org changed reviewers:
+ tommi@webrtc.org

[joachim, 2016-03-20 10:14:10]

ptal

https://codereview.webrtc.org/1823503002/diff/1/webrtc/media/sctp/sctpdataeng...
File webrtc/media/sctp/sctpdataengine.cc (right):

https://codereview.webrtc.org/1823503002/diff/1/webrtc/media/sctp/sctpdataeng...
webrtc/media/sctp/sctpdataengine.cc:175: const_cast<void*>(data), length,
direction)) != NULL) {
This is the change compared to https://codereview.webrtc.org/1785713005/

Also added a comment above as to why this has changed.

[joachim, 2016-03-20 10:14:24]

The CQ bit was checked by jbauch@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-20 10:14:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823503002/1

[joachim, 2016-03-20 10:25:59]

On 2016/03/20 10:14:10, joachim wrote:
> ptal
> 
>
https://codereview.webrtc.org/1823503002/diff/1/webrtc/media/sctp/sctpdataeng...
> File webrtc/media/sctp/sctpdataengine.cc (right):
> 
>
https://codereview.webrtc.org/1823503002/diff/1/webrtc/media/sctp/sctpdataeng...
> webrtc/media/sctp/sctpdataengine.cc:175: const_cast<void*>(data), length,
> direction)) != NULL) {
> This is the change compared to https://codereview.webrtc.org/1785713005/
> 
> Also added a comment above as to why this has changed.

Oh and for reference, the previously reviewed and landed CL was here:
https://codereview.webrtc.org/1785713005/

[commit-bot: I haz the power, 2016-03-20 11:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-20 11:36:49]

Dry run: This issue passed the CQ dry run.

[tommi, 2016-03-20 13:13:55]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-03-20 13:13:56]

lgtm

[commit-bot: I haz the power, 2016-03-20 13:14:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823503002/1

[commit-bot: I haz the power, 2016-03-20 13:15:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-20 13:15:52]

Description was changed from

==========
Reland Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies.

This CL removes copy and assign support from Buffer and changes various
parameters from Buffer to CopyOnWriteBuffer so they can be passed along
and copied without actually copying the underlying data.

With this changed some parameters to be "const" and fixed an issue when
creating a CopyOnWriteBuffer with empty data.

BUG=webrtc:5155
==========

to

==========
Reland Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies.

This CL removes copy and assign support from Buffer and changes various
parameters from Buffer to CopyOnWriteBuffer so they can be passed along
and copied without actually copying the underlying data.

With this changed some parameters to be "const" and fixed an issue when
creating a CopyOnWriteBuffer with empty data.

BUG=webrtc:5155

Committed: https://crrev.com/eec21bdae34bd63ebf568430488d6e25d8db9b4a
Cr-Commit-Position: refs/heads/master@{#12062}
==========

[commit-bot: I haz the power, 2016-03-20 13:15:53]

Patchset 1 (id:??) landed as
https://crrev.com/eec21bdae34bd63ebf568430488d6e25d8db9b4a
Cr-Commit-Position: refs/heads/master@{#12062}

[kjellander_webrtc, 2016-03-20 13:31:06]

kjellander@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2016-03-20 13:31:06]

Thanks for fixing this. All is green downstream. I'll try to make sure we enable
-fpermissive for Android.
lgtm