|
Reland Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies.
This CL removes copy and assign support from Buffer and changes various
parameters from Buffer to CopyOnWriteBuffer so they can be passed along
and copied without actually copying the underlying data.
With this changed some parameters to be "const" and fixed an issue when
creating a CopyOnWriteBuffer with empty data.
BUG= webrtc:5155
Committed: https://crrev.com/eec21bdae34bd63ebf568430488d6e25d8db9b4a
Cr-Commit-Position: refs/heads/master@{#12062}
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+299 lines, -247 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
talk/app/webrtc/objc/RTCDataChannel.mm
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/datachannel.h
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/datachannel.cc
|
View
|
|
3 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/datachannel_unittest.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/datachannelinterface.h
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/java/jni/peerconnection_jni.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/objc/RTCDataChannel.mm
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/peerconnectioninterface_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/sctputils.h
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/sctputils.cc
|
View
|
|
6 chunks |
+19 lines, -17 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/test/fakedatachannelprovider.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/webrtcsession.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/webrtcsession.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/api/webrtcsession_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/base/buffer.h
|
View
|
|
3 chunks |
+2 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/base/buffer.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/base/buffer_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -17 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/base/copyonwritebuffer.h
|
View
|
|
2 chunks |
+15 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/base/copyonwritebuffer_unittest.cc
|
View
|
|
3 chunks |
+61 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/base/sslfingerprint.h
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/fakemediaengine.h
|
View
|
|
4 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/fakenetworkinterface.h
|
View
|
|
8 chunks |
+14 lines, -15 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/mediachannel.h
|
View
|
|
6 chunks |
+11 lines, -9 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/rtpdataengine.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/rtpdataengine.cc
|
View
|
|
6 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/rtpdataengine_unittest.cc
|
View
|
|
9 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/base/videoengine_unittest.h
|
View
|
|
11 chunks |
+18 lines, -16 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcvideoengine2.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcvideoengine2.cc
|
View
|
|
7 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcvideoengine2_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcvoiceengine.h
|
View
|
|
2 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcvoiceengine.cc
|
View
|
|
5 chunks |
+10 lines, -12 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/engine/webrtcvoiceengine_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/sctp/sctpdataengine.h
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/sctp/sctpdataengine.cc
|
View
|
|
11 chunks |
+24 lines, -20 lines |
1 comment
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/media/sctp/sctpdataengine_unittest.cc
|
View
|
|
6 chunks |
+8 lines, -10 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/pc/channel.h
|
View
|
|
8 chunks |
+14 lines, -14 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/pc/channel.cc
|
View
|
|
10 chunks |
+12 lines, -12 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
webrtc/pc/channel_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 15 (6 generated)
|