Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1821513003: Rent-A-Codec: Reference count the shared iSAC bandwidth estimation state (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, ossu, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@acm-13
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rent-A-Codec: Reference count the shared iSAC bandwidth estimation state Now that the Rent-A-Codec no longer owns the encoders and decoders it produces, they may outlive it. It's thus no longer correct for the Rent-A-Codec to own the bandwidth estimation state; all of the involved objects need to share ownership. BUG=webrtc:5028 Committed: https://crrev.com/0d05da7ee65f19b5ccc67c9d6567ac1ef63c13c8 Cr-Commit-Position: refs/heads/master@{#12159}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
This should have been done at the same time as the change that made the ...
4 years, 9 months ago (2016-03-21 09:19:38 UTC) #2
hlundin-webrtc
lgtm
4 years, 8 months ago (2016-03-29 19:48:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821513003/1
4 years, 8 months ago (2016-03-30 10:10:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 11:10:16 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 11:10:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d05da7ee65f19b5ccc67c9d6567ac1ef63c13c8
Cr-Commit-Position: refs/heads/master@{#12159}

Powered by Google App Engine
This is Rietveld 408576698