AudioCodingModule: Add methods for injecting external encoder stacks

AudioCodingModule: Add methods for injecting external encoder stacks

BUG=webrtc:5028
Committed: https://crrev.com/4cdbd57fe3bc252e437035b0589d0fbf39200157
Cr-Commit-Position: refs/heads/master@{#12158}

[kwiberg-webrtc, 2016-02-08 14:50:33]

Description was changed from

==========
AudioCodingModule: Add methods for injecting external encoder stacks

BUG=webrtc:5028
==========

to

==========
AudioCodingModule: Add methods for injecting external encoder stacks

BUG=webrtc:5028
==========

[kwiberg-webrtc, 2016-02-08 14:50:33]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-02-10 09:45:46]

lgtm with one comment.

https://codereview.webrtc.org/1673213002/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc (right):

https://codereview.webrtc.org/1673213002/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc:224: void
AudioCodingModuleImpl::VisitEncoder(const EncoderVisitor& ev) {
Rename function to ModifyEncoder, or something similar.

[kwiberg-webrtc, 2016-03-17 05:33:16]

Patchset #3 (id:40001) has been deleted

[kwiberg-webrtc, 2016-03-21 09:12:58]

Patchset #3 (id:60001) has been deleted

[kwiberg-webrtc, 2016-03-21 09:15:24]

Please have another look. This is now rebased on top of the (landed) CL that
makes the Rent-A-Codec give away encoder ownership. Diff to previous patch set
is probably not useful.

[hlundin-webrtc, 2016-03-30 08:02:57]

lgtm

https://codereview.webrtc.org/1673213002/diff/80001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/include/audio_coding_module.h (right):

https://codereview.webrtc.org/1673213002/diff/80001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/include/audio_coding_module.h:219: class
FunctionView<RetT(ArgT...)> final {
This class is a whole lot of Greek++ to me, but I guess it works. From an
outside view, the class is defined and commented enough for the user to
understand it.

[kwiberg-webrtc, 2016-03-30 08:46:28]

https://codereview.webrtc.org/1673213002/diff/80001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/include/audio_coding_module.h (right):

https://codereview.webrtc.org/1673213002/diff/80001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/include/audio_coding_module.h:219: class
FunctionView<RetT(ArgT...)> final {
On 2016/03/30 08:02:57, hlundin-webrtc wrote:
> This class is a whole lot of Greek++ to me, but I guess it works. From an
> outside view, the class is defined and commented enough for the user to
> understand it.

If you're interested, I can walk you through how it works. It's actually quite
simple---it's just the C++ syntax and stuff that makes it hard to read...

[kwiberg-webrtc, 2016-03-30 09:11:09]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-03-30 09:11:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673213002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673213002/80001

[commit-bot: I haz the power, 2016-03-30 10:10:10]

Description was changed from

==========
AudioCodingModule: Add methods for injecting external encoder stacks

BUG=webrtc:5028
==========

to

==========
AudioCodingModule: Add methods for injecting external encoder stacks

BUG=webrtc:5028
==========

[commit-bot: I haz the power, 2016-03-30 10:10:11]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-03-30 10:10:23]

Description was changed from

==========
AudioCodingModule: Add methods for injecting external encoder stacks

BUG=webrtc:5028
==========

to

==========
AudioCodingModule: Add methods for injecting external encoder stacks

BUG=webrtc:5028

Committed: https://crrev.com/4cdbd57fe3bc252e437035b0589d0fbf39200157
Cr-Commit-Position: refs/heads/master@{#12158}
==========

[commit-bot: I haz the power, 2016-03-30 10:10:24]

Patchset 3 (id:??) landed as
https://crrev.com/4cdbd57fe3bc252e437035b0589d0fbf39200157
Cr-Commit-Position: refs/heads/master@{#12158}