Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1820133002: Implement CPU feature detection for ARM Linux. (Closed)

Created:
4 years, 9 months ago by Simon Hosie
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Implement CPU feature detection for ARM Linux. BUG=webrtc:5057 NOTRY=True Committed: https://crrev.com/953b1c185fcb4d9a1da063ca70a79f14b88c47a3 Cr-Commit-Position: refs/heads/master@{#12270}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixes for chromium and x86 builds #

Total comments: 15

Patch Set 3 : GN correction, dead file removal, formatting, stricter string structure test for AT_PLATFORM. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M webrtc/system_wrappers/BUILD.gn View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/cpu_features_webrtc.gyp View 1 2 chunks +15 lines, -0 lines 0 comments Download
A webrtc/system_wrappers/source/cpu_features_linux.c View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers.gyp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (10 generated)
kjellander_webrtc
https://codereview.webrtc.org/1820133002/diff/1/webrtc/system_wrappers/system_wrappers.gyp File webrtc/system_wrappers/system_wrappers.gyp (right): https://codereview.webrtc.org/1820133002/diff/1/webrtc/system_wrappers/system_wrappers.gyp#newcode127 webrtc/system_wrappers/system_wrappers.gyp:127: 'cpu_features_webrtc.gyp:cpu_features_linux', I'm not sure if this will compile fine ...
4 years, 8 months ago (2016-03-30 19:11:17 UTC) #2
Simon Hosie
On 2016/03/30 19:11:17, kjellander (webrtc) wrote: > https://codereview.webrtc.org/1820133002/diff/1/webrtc/system_wrappers/system_wrappers.gyp > File webrtc/system_wrappers/system_wrappers.gyp (right): > > https://codereview.webrtc.org/1820133002/diff/1/webrtc/system_wrappers/system_wrappers.gyp#newcode127 ...
4 years, 8 months ago (2016-04-02 01:08:51 UTC) #3
kjellander_webrtc
+torbjorng to review the C code in webrtc/system_wrappers/source/cpu_features_linux.c since my C skills are not sufficient ...
4 years, 8 months ago (2016-04-04 06:09:45 UTC) #5
torbjorng (webrtc)
The formatting of this file deviates from what we use in Chromium and WebRTC. Please ...
4 years, 8 months ago (2016-04-04 08:35:43 UTC) #6
torbjorng (webrtc)
Oops, one sentence there got too many typos to be readable. Let me try again: ...
4 years, 8 months ago (2016-04-04 10:59:39 UTC) #7
Simon Hosie
https://codereview.webrtc.org/1820133002/diff/20001/webrtc/system_wrappers/BUILD.gn File webrtc/system_wrappers/BUILD.gn (right): https://codereview.webrtc.org/1820133002/diff/20001/webrtc/system_wrappers/BUILD.gn#newcode111 webrtc/system_wrappers/BUILD.gn:111: deps += [ ":cpu_features_linux" ] On 2016/04/04 06:09:45, kjellander ...
4 years, 8 months ago (2016-04-05 01:15:48 UTC) #8
torbjorng (webrtc)
lgtm wrt cpu_features_linux.c.
4 years, 8 months ago (2016-04-05 08:27:28 UTC) #9
kjellander_webrtc
lgtm! Feel free to send this to the CQ if the trybots I've triggered are ...
4 years, 8 months ago (2016-04-05 09:27:51 UTC) #11
kjellander_webrtc
On 2016/04/05 09:27:51, kjellander (webrtc) wrote: > lgtm! > Feel free to send this to ...
4 years, 8 months ago (2016-04-05 09:31:01 UTC) #13
Johann
On 2016/04/05 09:27:51, kjellander (webrtc) wrote: > > I would have hoped so, but I ...
4 years, 8 months ago (2016-04-05 16:30:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820133002/40001
4 years, 8 months ago (2016-04-05 21:36:47 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4617)
4 years, 8 months ago (2016-04-05 21:47:39 UTC) #18
kjellander_webrtc
+henrikg@ for system_wrappers OWNERS
4 years, 8 months ago (2016-04-06 06:57:10 UTC) #20
Henrik Grunell WebRTC
Owners rs lgtm
4 years, 8 months ago (2016-04-06 07:01:10 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820133002/40001
4 years, 8 months ago (2016-04-06 21:00:59 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-06 21:02:31 UTC) #25
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 21:02:41 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/953b1c185fcb4d9a1da063ca70a79f14b88c47a3
Cr-Commit-Position: refs/heads/master@{#12270}

Powered by Google App Engine
This is Rietveld 408576698