Use rtc::scoped_refptr for WebRtcVideoCapturer.

Use rtc::scoped_refptr for WebRtcVideoCapturer.

Un-breaks peerconnection_client which would instantly use-after-free on
an allocated VCM because it wasn't building a scoped_refptr so all
references to the VCM were dropped.

BUG=webrtc:5229
TBR=tommi@webrtc.org
TEST=Run peerconnection_client locally, verify that there's no crash.

Committed: https://chromium.googlesource.com/external/webrtc/+/09c3a1e291ed5a59d9c6f54b9ea5a7c2e2acec5c

[pbos-webrtc, 2016-03-22 14:33:45]

PTAL, I'm hoping this is the last of them. :\

[pbos-webrtc, 2016-03-22 14:37:40]

remove incorrect early return

[pbos-webrtc, 2016-03-22 14:39:44]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 14:39:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817953005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817953005/20001

[pbos-webrtc, 2016-03-22 16:16:38]

pbos@webrtc.org changed reviewers:
+ stefan@webrtc.org
- tommi@webrtc.org

[pbos-webrtc, 2016-03-22 16:16:39]

stefan@ can you review this after the fact? It's fixing a crash

[pbos-webrtc, 2016-03-22 16:16:49]

Description was changed from

==========
Use rtc::scoped_refptr for WebRtcVideoCapturer.

Un-breaks peerconnection_client which would instantly use-after-free on
an allocated VCM because it wasn't building a scoped_refptr so all
references to the VCM were dropped.

BUG=webrtc:5229
R=tommi@webrtc.org
TEST=Run peerconnection_client locally, verify that there's no crash.
==========

to

==========
Use rtc::scoped_refptr for WebRtcVideoCapturer.

Un-breaks peerconnection_client which would instantly use-after-free on
an allocated VCM because it wasn't building a scoped_refptr so all
references to the VCM were dropped.

BUG=webrtc:5229
TBR=tommi@webrtc.org
TEST=Run peerconnection_client locally, verify that there's no crash.
==========

[pbos-webrtc, 2016-03-22 16:17:50]

Description was changed from

==========
Use rtc::scoped_refptr for WebRtcVideoCapturer.

Un-breaks peerconnection_client which would instantly use-after-free on
an allocated VCM because it wasn't building a scoped_refptr so all
references to the VCM were dropped.

BUG=webrtc:5229
TBR=tommi@webrtc.org
TEST=Run peerconnection_client locally, verify that there's no crash.
==========

to

==========
Use rtc::scoped_refptr for WebRtcVideoCapturer.

Un-breaks peerconnection_client which would instantly use-after-free on
an allocated VCM because it wasn't building a scoped_refptr so all
references to the VCM were dropped.

BUG=webrtc:5229
TBR=stefan@webrtc.org
TEST=Run peerconnection_client locally, verify that there's no crash.
==========

[commit-bot: I haz the power, 2016-03-22 16:17:51]

Description was changed from

==========
Use rtc::scoped_refptr for WebRtcVideoCapturer.

Un-breaks peerconnection_client which would instantly use-after-free on
an allocated VCM because it wasn't building a scoped_refptr so all
references to the VCM were dropped.

BUG=webrtc:5229
TBR=stefan@webrtc.org
TEST=Run peerconnection_client locally, verify that there's no crash.
==========

to

==========
Use rtc::scoped_refptr for WebRtcVideoCapturer.

Un-breaks peerconnection_client which would instantly use-after-free on
an allocated VCM because it wasn't building a scoped_refptr so all
references to the VCM were dropped.

BUG=webrtc:5229
TBR=tommi@webrtc.org
TEST=Run peerconnection_client locally, verify that there's no crash.

Committed: https://crrev.com/09c3a1e291ed5a59d9c6f54b9ea5a7c2e2acec5c
Cr-Commit-Position: refs/heads/master@{#12088}
==========

[pbos-webrtc, 2016-03-22 16:17:52]

Description was changed from

==========
Use rtc::scoped_refptr for WebRtcVideoCapturer.

Un-breaks peerconnection_client which would instantly use-after-free on
an allocated VCM because it wasn't building a scoped_refptr so all
references to the VCM were dropped.

BUG=webrtc:5229
TBR=tommi@webrtc.org
TEST=Run peerconnection_client locally, verify that there's no crash.

Committed: https://crrev.com/09c3a1e291ed5a59d9c6f54b9ea5a7c2e2acec5c
Cr-Commit-Position: refs/heads/master@{#12088}
==========

to

==========
Use rtc::scoped_refptr for WebRtcVideoCapturer.

Un-breaks peerconnection_client which would instantly use-after-free on
an allocated VCM because it wasn't building a scoped_refptr so all
references to the VCM were dropped.

BUG=webrtc:5229
TBR=tommi@webrtc.org
TEST=Run peerconnection_client locally, verify that there's no crash.

Committed:
https://chromium.googlesource.com/external/webrtc/+/09c3a1e291ed5a59d9c6f54b9...
==========

[commit-bot: I haz the power, 2016-03-22 16:17:52]

Patchset 2 (id:??) landed as
https://crrev.com/09c3a1e291ed5a59d9c6f54b9ea5a7c2e2acec5c
Cr-Commit-Position: refs/heads/master@{#12088}

[pbos-webrtc, 2016-03-22 16:17:53]

Committed patchset #2 (id:20001) manually as
09c3a1e291ed5a59d9c6f54b9ea5a7c2e2acec5c (presubmit successful).

[kjellander_webrtc, 2016-03-22 16:59:29]

On 2016/03/22 16:17:53, pbos-webrtc wrote:
> Committed patchset #2 (id:20001) manually as
> 09c3a1e291ed5a59d9c6f54b9ea5a7c2e2acec5c (presubmit successful).

Would it be possible to add a unit test that exercises the code path in
peerconnection_client that crashed, so we can prevent this from happening again?

[pbos-webrtc, 2016-03-22 17:13:22]

On 2016/03/22 16:59:29, kjellander (webrtc) wrote:
> On 2016/03/22 16:17:53, pbos-webrtc wrote:
> > Committed patchset #2 (id:20001) manually as
> > 09c3a1e291ed5a59d9c6f54b9ea5a7c2e2acec5c (presubmit successful).
> 
> Would it be possible to add a unit test that exercises the code path in
> peerconnection_client that crashed, so we can prevent this from happening
again?

Not trivially as far as I can tell (short of running peerconnection_client). It
should be a one-off thing because I don't see anyone refactoring this back to
not use scoped_refptrs.