Chromium Code Reviews

Unified Diff: webrtc/media/engine/fakewebrtcvideocapturemodule.h

Issue 1817953005: Use rtc::scoped_refptr for WebRtcVideoCapturer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: remove incorrect early return Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « webrtc/media/engine/fakewebrtcvcmfactory.h ('k') | webrtc/media/engine/webrtcvideocapturer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/fakewebrtcvideocapturemodule.h
diff --git a/webrtc/media/engine/fakewebrtcvideocapturemodule.h b/webrtc/media/engine/fakewebrtcvideocapturemodule.h
index b2fe4590002b6b36117beafc545ef362bf10c8db..3202502e6c512b041a863ae367011389d86987dc 100644
--- a/webrtc/media/engine/fakewebrtcvideocapturemodule.h
+++ b/webrtc/media/engine/fakewebrtcvideocapturemodule.h
@@ -28,6 +28,7 @@ class FakeWebRtcVideoCaptureModule : public webrtc::VideoCaptureModule {
running_(false),
delay_(0) {
}
+ ~FakeWebRtcVideoCaptureModule();
int64_t TimeUntilNextProcess() override { return 0; }
void Process() override {}
void RegisterCaptureDataCallback(
@@ -83,11 +84,6 @@ class FakeWebRtcVideoCaptureModule : public webrtc::VideoCaptureModule {
const webrtc::VideoCodec& codec) override {
return NULL; // not implemented
}
- int32_t AddRef() const override { return 0; }
- int32_t Release() const override {
- delete this;
- return 0;
- }
void SendFrame(int w, int h) {
if (!running_) return;
@@ -104,9 +100,6 @@ class FakeWebRtcVideoCaptureModule : public webrtc::VideoCaptureModule {
}
private:
- // Ref-counted, use Release() instead.
- ~FakeWebRtcVideoCaptureModule();
-
FakeWebRtcVcmFactory* factory_;
int id_;
webrtc::VideoCaptureDataCallback* callback_;
« no previous file with comments | « webrtc/media/engine/fakewebrtcvcmfactory.h ('k') | webrtc/media/engine/webrtcvideocapturer.h » ('j') | no next file with comments »

Powered by Google App Engine