Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1816723002: Fix potential crashes in the screen capturer on Mac (Closed)

Created:
4 years, 9 months ago by Sergey Ulanov
Modified:
4 years, 9 months ago
Reviewers:
jiayl2
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix potential crashes in the screen capturer on Mac ScreenCapturerMac wasn't handling the following two cases properly which could cause crashes: 1. CGDisplayCreateImage() returns image with depth other than 32-bit 2. CGDisplayCreateImage() returns image with dimensions different from expected (e.g. when screen resolution is being changed). I suspect that (2) was causing the linked bug. BUG=crbug.com/504927 R=jiayl@webrtc.org Committed: https://crrev.com/0c4de568a632395ca12c57b0600d5d64b5fc91f1 Cr-Commit-Position: refs/heads/master@{#12077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -43 lines) Patch
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 5 chunks +50 lines, -43 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Sergey Ulanov
4 years, 9 months ago (2016-03-18 23:03:56 UTC) #2
jiayl2
lgtm
4 years, 9 months ago (2016-03-18 23:23:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816723002/1
4 years, 9 months ago (2016-03-18 23:26:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 9 months ago (2016-03-19 01:26:55 UTC) #7
Sergey Ulanov
Committed patchset #1 (id:1) manually as 0c4de568a632395ca12c57b0600d5d64b5fc91f1 (presubmit successful).
4 years, 9 months ago (2016-03-21 18:18:58 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 18:19:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c4de568a632395ca12c57b0600d5d64b5fc91f1
Cr-Commit-Position: refs/heads/master@{#12077}

Powered by Google App Engine
This is Rietveld 408576698