Removed MediaStreamTrackInterface::set_state

Removed MediaStreamTrackInterface::set_state
The track state should be implicitly set by the underlying source. 
This removes the public method and cleans up how AudioRtpReceiver is created. Further more it cleans up how the RtpReceivers are destroyed.

Note that this cl depend on https://codereview.webrtc.org/1790633002.
BUG=webrtc:5426

[perkj_webrtc, 2016-03-21 15:33:58]

Description was changed from

==========
Removed MediaStreamTrack::set_state

BUG=
==========

to

==========
Removed MediaStreamTrackInterface::set_state
The track state should be implicitly set by the underlying source. 
This removes the public method and cleans up how AudioRtpReceiver is created.
Further more it cleans up how the RtpReceivers are destroyed.

Note that this cl depend on https://codereview.webrtc.org/1790633002.
BUG=webrtc:5426
==========

[perkj_webrtc, 2016-03-21 16:18:05]

perkj@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[perkj_webrtc, 2016-03-21 16:18:06]

Please?

https://codereview.webrtc.org/1816143002/diff/1/webrtc/api/peerconnection.h
File webrtc/api/peerconnection.h (right):

https://codereview.webrtc.org/1816143002/diff/1/webrtc/api/peerconnection.h#n...
webrtc/api/peerconnection.h:15: #include <map>
to make cl lint happy.

[Taylor Brandstetter, 2016-03-21 18:49:55]

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/peerconnection.cc
File webrtc/api/peerconnection.cc (right):

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/peerconnection...
webrtc/api/peerconnection.cc:1953: DestroyReceivers(cricket::MEDIA_TYPE_AUDIO);
I don't think this should go so far as to destroy the receivers. They shouldn't
be destroyed until a remote description is set that removes them. But just
calling the "Stop" method on the receivers should be ok.

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/peerconnection...
File webrtc/api/peerconnectioninterface_unittest.cc (right):

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface_unittest.cc:1874: 0);  // Audio source state
changes are posted.
Why not use "EXPECT_EQ_WAIT" instead of "ProcessMessages"?

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface_unittest.cc:2000: 0);  // Audio source state
changes are posted.
Same here.

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/rtpreceiver.h
File webrtc/api/rtpreceiver.h (right):

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/rtpreceiver.h#...
webrtc/api/rtpreceiver.h:66: // the VideoRtpReceiver is stopped.
Is this comment still valid? Also, change "Video" to "Audio"

[perkj_webrtc, 2016-03-22 16:59:53]

perkj@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[perkj_webrtc, 2016-03-22 16:59:54]

Adding Zeke for the IOS changes. 

Can you please review?

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/peerconnection.cc
File webrtc/api/peerconnection.cc (right):

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/peerconnection...
webrtc/api/peerconnection.cc:1953: DestroyReceivers(cricket::MEDIA_TYPE_AUDIO);
On 2016/03/21 18:49:54, Taylor Brandstetter wrote:
> I don't think this should go so far as to destroy the receivers. They
shouldn't
> be destroyed until a remote description is set that removes them. But just
> calling the "Stop" method on the receivers should be ok.

Done.

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/peerconnection...
File webrtc/api/peerconnectioninterface_unittest.cc (right):

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface_unittest.cc:1874: 0);  // Audio source state
changes are posted.
On 2016/03/21 18:49:54, Taylor Brandstetter wrote:
> Why not use "EXPECT_EQ_WAIT" instead of "ProcessMessages"?

Done.

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface_unittest.cc:2000: 0);  // Audio source state
changes are posted.
On 2016/03/21 18:49:54, Taylor Brandstetter wrote:
> Same here.

Done.

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/rtpreceiver.h
File webrtc/api/rtpreceiver.h (right):

https://codereview.webrtc.org/1816143002/diff/40001/webrtc/api/rtpreceiver.h#...
webrtc/api/rtpreceiver.h:66: // the VideoRtpReceiver is stopped.
On 2016/03/21 18:49:54, Taylor Brandstetter wrote:
> Is this comment still valid? Also, change "Video" to "Audio"

actually no.

[tkchin_webrtc, 2016-03-22 17:02:53]

lgtm for objc stuff
the ios gn bots don't work, so ignore those failures. You can run on any other
ios bot that doesn't have GN in it.

[perkj_webrtc, 2016-03-23 20:14:07]

pthatcher and or / deadbeef  please take a look at this today if you have time. 
The prerequisite cl is landed.

[Taylor Brandstetter, 2016-03-23 21:49:45]

lgtm. Great work on this.

[perkj_webrtc, 2016-03-24 07:28:22]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-03-24 07:28:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816143002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816143002/80001

[commit-bot: I haz the power, 2016-03-24 07:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 07:29:44]

Try jobs failed on following builders:
  mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/1857)
  mac_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/8086)

[perkj_webrtc, 2016-03-24 09:16:43]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-03-24 09:16:43]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org,
tkchin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1816143002/#ps100001 (title:
"Rebased")

[commit-bot: I haz the power, 2016-03-24 09:16:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1816143002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1816143002/100001

[commit-bot: I haz the power, 2016-03-24 10:16:25]

Description was changed from

==========
Removed MediaStreamTrackInterface::set_state
The track state should be implicitly set by the underlying source. 
This removes the public method and cleans up how AudioRtpReceiver is created.
Further more it cleans up how the RtpReceivers are destroyed.

Note that this cl depend on https://codereview.webrtc.org/1790633002.
BUG=webrtc:5426
==========

to

==========
Removed MediaStreamTrackInterface::set_state
The track state should be implicitly set by the underlying source. 
This removes the public method and cleans up how AudioRtpReceiver is created.
Further more it cleans up how the RtpReceivers are destroyed.

Note that this cl depend on https://codereview.webrtc.org/1790633002.
BUG=webrtc:5426
==========

[commit-bot: I haz the power, 2016-03-24 10:16:26]

Description was changed from

==========
Removed MediaStreamTrackInterface::set_state
The track state should be implicitly set by the underlying source. 
This removes the public method and cleans up how AudioRtpReceiver is created.
Further more it cleans up how the RtpReceivers are destroyed.

Note that this cl depend on https://codereview.webrtc.org/1790633002.
BUG=webrtc:5426
==========

to

==========
Removed MediaStreamTrackInterface::set_state
The track state should be implicitly set by the underlying source.
This removes the public method and cleans up how AudioRtpReceiver is created.
Further more it cleans up how the RtpReceivers are destroyed.

Note that this cl depend on https://codereview.webrtc.org/1790633002.
BUG=webrtc:5426

Committed: https://crrev.com/d61bf803d2949fb804c61a77c53ee9dd58c6d653
Cr-Commit-Position: refs/heads/master@{#12115}
==========

[commit-bot: I haz the power, 2016-03-24 10:16:26]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-24 10:16:27]

Patchset 6 (id:??) landed as
https://crrev.com/d61bf803d2949fb804c61a77c53ee9dd58c6d653
Cr-Commit-Position: refs/heads/master@{#12115}