Propagate MediaStreamSource state to video tracks the same way as audio.

Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states kInitializing and kFailed.

BUG=webrtc:5426
Committed: https://crrev.com/c8f952deaae5eccadf218bb0300ee49b50a87ce8
Cr-Commit-Position: refs/heads/master@{#12098}

[perkj_webrtc, 2016-03-11 18:47:07]

The CQ bit was checked by perkj@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 18:47:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1790633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1790633002/20001

[perkj_webrtc, 2016-03-11 18:47:32]

perkj@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[perkj_webrtc, 2016-03-11 18:47:33]

Please?

[commit-bot: I haz the power, 2016-03-11 18:49:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 18:49:29]

Dry run: Try jobs failed on following builders:
  ios64_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/5882)

[perkj_webrtc, 2016-03-11 23:59:21]

Description was changed from

==========
Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states.
Since this also required a Video source to exist in all unit tests that create a
track, a FakeVideoTrackSource is added and used in tests.

BUG=
==========

to

==========
Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states kLive and kFailed.
Since this also required a Video source to exist in all unit tests that create a
track, a FakeVideoTrackSource is added and used in tests.

BUG=webrtc:5426
==========

[perkj_webrtc, 2016-03-17 12:19:31]

perkj@webrtc.org changed reviewers:
+ nisse@webrtc.org

[perkj_webrtc, 2016-03-17 12:19:32]

Adding Nisse as well.

[nisse-webrtc, 2016-03-17 12:39:30]

I don't understand the fine details of these states, but changes lgtm.

https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaStreamTrack.h (right):

https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.h:15: * which include two more states than
are in the W3C spec.
Comment needs to be update or deleted, I guess?

[nisse-webrtc, 2016-03-17 12:53:08]

On 2016/03/17 12:39:30, nisse-webrtc wrote:
> I don't understand the fine details of these states, but changes lgtm.
> 
>
https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/objc/RTCMediaS...
> File webrtc/api/objc/RTCMediaStreamTrack.h (right):
> 
>
https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/objc/RTCMediaS...
> webrtc/api/objc/RTCMediaStreamTrack.h:15: * which include two more states than
> are in the W3C spec.
> Comment needs to be update or deleted, I guess?

There's a duplicate FakeVideoTrackSource in rtpsenderreceiver_unittest.cc.

[Taylor Brandstetter, 2016-03-18 16:08:21]

https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/mediastream_un...
File webrtc/api/mediastream_unittest.cc (right):

https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/mediastream_un...
webrtc/api/mediastream_unittest.cc:87:
track->set_state(MediaStreamTrackInterface::kEnded);
If the track's state is determined by it source, it seems like "set_state"
shouldn't be public. Then this test could work by setting the state of the
FakeVideoTrackSource.

[perkj_webrtc, 2016-03-20 14:05:20]

Patchset #7 (id:110001) has been deleted

[perkj_webrtc, 2016-03-20 14:06:09]

perkj@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[perkj_webrtc, 2016-03-20 14:06:10]

Adding pthatcher as well.

https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/objc/RTCMediaS...
File webrtc/api/objc/RTCMediaStreamTrack.h (right):

https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/objc/RTCMediaS...
webrtc/api/objc/RTCMediaStreamTrack.h:15: * which include two more states than
are in the W3C spec.
On 2016/03/17 12:39:29, nisse-webrtc wrote:
> Comment needs to be update or deleted, I guess?

Done.

[perkj_webrtc, 2016-03-20 14:09:07]

https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/mediastream_un...
File webrtc/api/mediastream_unittest.cc (right):

https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/mediastream_un...
webrtc/api/mediastream_unittest.cc:87:
track->set_state(MediaStreamTrackInterface::kEnded);
On 2016/03/18 16:08:21, Taylor Brandstetter wrote:
> If the track's state is determined by it source, it seems like "set_state"
> shouldn't be public. Then this test could work by setting the state of the
> FakeVideoTrackSource.

I think that is a good idea but it requires a larger change. the audio RTP
receiver needs to be updated to change the state of the remote audio source. The
code for change the track state when the video or voice channel is destroyed
should probably also be changed to destroy the rtp receiver or at least stop
them.
I would like to leave that to a later cl.

[perkj_webrtc, 2016-03-21 16:18:36]

On 2016/03/20 14:09:07, perkj_webrtc wrote:
>
https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/mediastream_un...
> File webrtc/api/mediastream_unittest.cc (right):
> 
>
https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/mediastream_un...
> webrtc/api/mediastream_unittest.cc:87:
> track->set_state(MediaStreamTrackInterface::kEnded);
> On 2016/03/18 16:08:21, Taylor Brandstetter wrote:
> > If the track's state is determined by it source, it seems like "set_state"
> > shouldn't be public. Then this test could work by setting the state of the
> > FakeVideoTrackSource.
> 
> I think that is a good idea but it requires a larger change. the audio RTP
> receiver needs to be updated to change the state of the remote audio source.
The
> code for change the track state when the video or voice channel is destroyed
> should probably also be changed to destroy the rtp receiver or at least stop
> them.
> I would like to leave that to a later cl.

Later is now :-) -> https://codereview.webrtc.org/1816143002

[Taylor Brandstetter, 2016-03-22 00:52:19]

On 2016/03/21 16:18:36, perkj_webrtc wrote:
> On 2016/03/20 14:09:07, perkj_webrtc wrote:
> >
>
https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/mediastream_un...
> > File webrtc/api/mediastream_unittest.cc (right):
> > 
> >
>
https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/mediastream_un...
> > webrtc/api/mediastream_unittest.cc:87:
> > track->set_state(MediaStreamTrackInterface::kEnded);
> > On 2016/03/18 16:08:21, Taylor Brandstetter wrote:
> > > If the track's state is determined by it source, it seems like "set_state"
> > > shouldn't be public. Then this test could work by setting the state of the
> > > FakeVideoTrackSource.
> > 
> > I think that is a good idea but it requires a larger change. the audio RTP
> > receiver needs to be updated to change the state of the remote audio source.
> The
> > code for change the track state when the video or voice channel is destroyed
> > should probably also be changed to destroy the rtp receiver or at least stop
> > them.
> > I would like to leave that to a later cl.
> 
> Later is now :-) -> https://codereview.webrtc.org/1816143002

In that case, lgtm.

[Taylor Brandstetter, 2016-03-22 00:52:20]

On 2016/03/21 16:18:36, perkj_webrtc wrote:
> On 2016/03/20 14:09:07, perkj_webrtc wrote:
> >
>
https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/mediastream_un...
> > File webrtc/api/mediastream_unittest.cc (right):
> > 
> >
>
https://codereview.webrtc.org/1790633002/diff/90001/webrtc/api/mediastream_un...
> > webrtc/api/mediastream_unittest.cc:87:
> > track->set_state(MediaStreamTrackInterface::kEnded);
> > On 2016/03/18 16:08:21, Taylor Brandstetter wrote:
> > > If the track's state is determined by it source, it seems like "set_state"
> > > shouldn't be public. Then this test could work by setting the state of the
> > > FakeVideoTrackSource.
> > 
> > I think that is a good idea but it requires a larger change. the audio RTP
> > receiver needs to be updated to change the state of the remote audio source.
> The
> > code for change the track state when the video or voice channel is destroyed
> > should probably also be changed to destroy the rtp receiver or at least stop
> > them.
> > I would like to leave that to a later cl.
> 
> Later is now :-) -> https://codereview.webrtc.org/1816143002

In that case, lgtm.

[perkj_webrtc, 2016-03-22 10:19:08]

perkj@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[perkj_webrtc, 2016-03-22 10:19:09]

Zeke - can you take a look at the IOS changes?

[tkchin_webrtc, 2016-03-22 16:19:13]

lgtm

[pthatcher1, 2016-03-22 21:22:28]

lgtm

[perkj_webrtc, 2016-03-23 07:30:30]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-03-23 07:30:31]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org,
deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1790633002/#ps190001 (title:
"Fix bug with wrong enum values.")

[commit-bot: I haz the power, 2016-03-23 07:30:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1790633002/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1790633002/190001

[commit-bot: I haz the power, 2016-03-23 07:34:01]

Description was changed from

==========
Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states kLive and kFailed.
Since this also required a Video source to exist in all unit tests that create a
track, a FakeVideoTrackSource is added and used in tests.

BUG=webrtc:5426
==========

to

==========
Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states kLive and kFailed.
Since this also required a Video source to exist in all unit tests that create a
track, a FakeVideoTrackSource is added and used in tests.

BUG=webrtc:5426
==========

[commit-bot: I haz the power, 2016-03-23 07:34:02]

Committed patchset #10 (id:190001)

[commit-bot: I haz the power, 2016-03-23 07:34:05]

Description was changed from

==========
Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states kLive and kFailed.
Since this also required a Video source to exist in all unit tests that create a
track, a FakeVideoTrackSource is added and used in tests.

BUG=webrtc:5426
==========

to

==========
Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states kLive and kFailed.
Since this also required a Video source to exist in all unit tests that create a
track, a FakeVideoTrackSource is added and used in tests.

BUG=webrtc:5426

Committed: https://crrev.com/c8f952deaae5eccadf218bb0300ee49b50a87ce8
Cr-Commit-Position: refs/heads/master@{#12098}
==========

[commit-bot: I haz the power, 2016-03-23 07:34:06]

Patchset 10 (id:??) landed as
https://crrev.com/c8f952deaae5eccadf218bb0300ee49b50a87ce8
Cr-Commit-Position: refs/heads/master@{#12098}

[perkj_webrtc, 2016-03-23 09:30:20]

Description was changed from

==========
Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states kLive and kFailed.
Since this also required a Video source to exist in all unit tests that create a
track, a FakeVideoTrackSource is added and used in tests.

BUG=webrtc:5426

Committed: https://crrev.com/c8f952deaae5eccadf218bb0300ee49b50a87ce8
Cr-Commit-Position: refs/heads/master@{#12098}
==========

to

==========
Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states kInitializing and kFailed.
Since this also required a Video source to exist in all unit tests that create a
track, a FakeVideoTrackSource is added and used in tests.

BUG=webrtc:5426

Committed: https://crrev.com/c8f952deaae5eccadf218bb0300ee49b50a87ce8
Cr-Commit-Position: refs/heads/master@{#12098}
==========

[perkj_webrtc, 2016-03-23 09:30:39]

Description was changed from

==========
Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states kInitializing and kFailed.
Since this also required a Video source to exist in all unit tests that create a
track, a FakeVideoTrackSource is added and used in tests.

BUG=webrtc:5426

Committed: https://crrev.com/c8f952deaae5eccadf218bb0300ee49b50a87ce8
Cr-Commit-Position: refs/heads/master@{#12098}
==========

to

==========
Propagate MediaStreamSource state to video tracks the same way as audio.
Also removes unused track states kInitializing and kFailed.

BUG=webrtc:5426

Committed: https://crrev.com/c8f952deaae5eccadf218bb0300ee49b50a87ce8
Cr-Commit-Position: refs/heads/master@{#12098}
==========