Put config in sync between gyp and gn.

Put config in sync between gyp and gn.

webrtc/base/base.gyp unconditionally set SSL_USE_OPENSSL and
HAVE_OPENSSL_SSL_H, fix webrtc/base/BUILD.gn to do the same.

Better implementation than https://codereview.webrtc.org/1441323002
to fix the same underlying issue (i.e. compilation on iOS).

BUG=459705
Committed: https://crrev.com/0db3db94e5ddde90f37120c8b67866b5c7d5a5f0
Cr-Commit-Position: refs/heads/master@{#12078}

[sdefresne, 2016-03-18 15:30:04]

sdefresne@chromium.org changed reviewers:
+ kjellander@webrtc.org, perkj@webrtc.org

[sdefresne, 2016-03-18 15:30:05]

Please take a look.

[kjellander_webrtc, 2016-03-18 15:49:54]

On 2016/03/18 15:30:05, sdefresne wrote:
> Please take a look.

sdefresne had a look at this in Paris today and came up with this solution. As
this blocks Chrome on iOS to build with GN I think it makes sense to change our
GN build this way to make it set the same defines as the GYP build.
lgtm

[kjellander_webrtc, 2016-03-18 15:50:25]

On 2016/03/18 15:49:54, kjellander (webrtc) wrote:
> On 2016/03/18 15:30:05, sdefresne wrote:
> > Please take a look.
> 
> sdefresne had a look at this in Paris today and came up with this solution. As
> this blocks Chrome on iOS to build with GN I think it makes sense to change
our
> GN build this way to make it set the same defines as the GYP build.
> lgtm

sdefresne and I is what I meant above (since I'm there visiting).

[sdefresne, 2016-03-21 14:14:21]

perkj: ping?

[perkj_webrtc, 2016-03-21 16:35:34]

I will have to trust kjellander.
rs lgtm

[sdefresne, 2016-03-21 16:39:07]

Description was changed from

==========
Put config in sync between gyp and gn.

webrtc/base/base.gyp unconditionally set SSL_USE_OPENSSL and
HAVE_OPENSSL_SSL_H, fix webrtc/base/BUILD.gn to do the same.

Better implementation that https://codereview.webrtc.org/1441323002
to fix the same underlying issue (i.e. compilation on iOS).

BUG=459705
==========

to

==========
Put config in sync between gyp and gn.

webrtc/base/base.gyp unconditionally set SSL_USE_OPENSSL and
HAVE_OPENSSL_SSL_H, fix webrtc/base/BUILD.gn to do the same.

Better implementation than https://codereview.webrtc.org/1441323002
to fix the same underlying issue (i.e. compilation on iOS).

BUG=459705
==========

[sdefresne, 2016-03-21 16:39:14]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-03-21 16:39:15]

Thank you both.

[commit-bot: I haz the power, 2016-03-21 16:39:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812213002/1

[commit-bot: I haz the power, 2016-03-21 18:20:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-21 18:20:38]

Description was changed from

==========
Put config in sync between gyp and gn.

webrtc/base/base.gyp unconditionally set SSL_USE_OPENSSL and
HAVE_OPENSSL_SSL_H, fix webrtc/base/BUILD.gn to do the same.

Better implementation than https://codereview.webrtc.org/1441323002
to fix the same underlying issue (i.e. compilation on iOS).

BUG=459705
==========

to

==========
Put config in sync between gyp and gn.

webrtc/base/base.gyp unconditionally set SSL_USE_OPENSSL and
HAVE_OPENSSL_SSL_H, fix webrtc/base/BUILD.gn to do the same.

Better implementation than https://codereview.webrtc.org/1441323002
to fix the same underlying issue (i.e. compilation on iOS).

BUG=459705

Committed: https://crrev.com/0db3db94e5ddde90f37120c8b67866b5c7d5a5f0
Cr-Commit-Position: refs/heads/master@{#12078}
==========

[commit-bot: I haz the power, 2016-03-21 18:20:39]

Patchset 1 (id:??) landed as
https://crrev.com/0db3db94e5ddde90f37120c8b67866b5c7d5a5f0
Cr-Commit-Position: refs/heads/master@{#12078}