Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1810373003: [iOS] Link with base/maccocoathreadhelper.mm on iOS. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
CC:
tterriberry_mozilla.com, webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@fix-ios
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[iOS] Link with base/maccocoathreadhelper.mm on iOS. rtc::ThreadManager::ThreadManager() calls rtc::InitCocoaMultiThreading() on iOS so add base/maccocoathreadhelper.mm to the file to build on iOS. Fixes the following linker error: Undefined symbols for architecture x86_64: "rtc::InitCocoaMultiThreading()", referenced from: rtc::ThreadManager::ThreadManager() in librtc_base.a(thread.o) BUG=459705 NOTRY=True Committed: https://crrev.com/60624cd6bf29c75e02009bd6149ecfb9cb877c7b Cr-Commit-Position: refs/heads/master@{#12085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (7 generated)
sdefresne
Please take a look.
4 years, 9 months ago (2016-03-18 17:16:25 UTC) #2
kjellander_webrtc
lgtm, thanks for spotting this. Keeping GYP and GN in sync is hard. We have ...
4 years, 9 months ago (2016-03-20 09:52:58 UTC) #3
sdefresne
perkj: ping?
4 years, 9 months ago (2016-03-21 14:14:32 UTC) #4
perkj_webrtc
lgtm
4 years, 9 months ago (2016-03-21 16:27:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810373003/1
4 years, 9 months ago (2016-03-22 09:13:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11951)
4 years, 9 months ago (2016-03-22 10:09:42 UTC) #9
kjellander_webrtc
On 2016/03/22 10:09:42, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 9 months ago (2016-03-22 10:20:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810373003/1
4 years, 9 months ago (2016-03-22 10:26:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 10:32:18 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 10:32:31 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60624cd6bf29c75e02009bd6149ecfb9cb877c7b
Cr-Commit-Position: refs/heads/master@{#12085}

Powered by Google App Engine
This is Rietveld 408576698