Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1807673008: Revert of Change VideoCapture_apply_rotation default to false (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, mflodman, sdk-team_agora.io
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Change VideoCapture_apply_rotation default to false (patchset #4 id:80001 of https://codereview.webrtc.org/1779883004/ ) Reason for revert: Seems to break on linux ubsan https://build.chromium.org/p/client.webrtc/builders/Linux%20UBSan/builds/247 Original issue's description: > Change VideoCapture_apply_rotation default to false > > BUG=webrtc:5621 > R=pthatcher@webrtc.org > > Committed: https://crrev.com/6919457319b0088ed8b68db30f68a03966d67121 > Cr-Commit-Position: refs/heads/master@{#12052} TBR=pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5621 Committed: https://crrev.com/223b982785573323aa399de4f2e551cadbaace8d Cr-Commit-Position: refs/heads/master@{#12053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M webrtc/media/base/videobroadcaster_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videocapturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videocapturer_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/base/videoframefactory.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/base/videosourceinterface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_webrtc
Created Revert of Change VideoCapture_apply_rotation default to false
4 years, 9 months ago (2016-03-18 17:06:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807673008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807673008/1
4 years, 9 months ago (2016-03-18 17:06:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 17:06:32 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/223b982785573323aa399de4f2e551cadbaace8d Cr-Commit-Position: refs/heads/master@{#12053}
4 years, 9 months ago (2016-03-18 17:06:47 UTC) #6
Taylor Brandstetter
4 years, 9 months ago (2016-03-18 18:38:18 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1809943006/ by deadbeef@webrtc.org.

The reason for reverting is: Relanding because this doesn't actually break the
bot. The issue the caused the test to crash on the bot should be fixed by:
https://codereview.webrtc.org/1815733002/.

Powered by Google App Engine
This is Rietveld 408576698