Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: webrtc/media/base/videocapturer_unittest.cc

Issue 1807673008: Revert of Change VideoCapture_apply_rotation default to false (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/videocapturer.cc ('k') | webrtc/media/base/videoframefactory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/videocapturer_unittest.cc
diff --git a/webrtc/media/base/videocapturer_unittest.cc b/webrtc/media/base/videocapturer_unittest.cc
index 40c770608f9dfb547fc84e25389cd9db6d8f24db..0d5a59e9b7d39c3cf1ae3b8dd8106f648cd3f805 100644
--- a/webrtc/media/base/videocapturer_unittest.cc
+++ b/webrtc/media/base/videocapturer_unittest.cc
@@ -116,10 +116,6 @@
cricket::FOURCC_I420));
capturer_->ResetSupportedFormats(formats);
- rtc::VideoSinkWants wants;
- // |capturer_| should compensate rotation.
- wants.rotation_applied = true;
- capturer_->AddOrUpdateSink(&renderer_, wants);
// capturer_ should compensate rotation as default.
EXPECT_EQ(cricket::CS_RUNNING,
@@ -158,7 +154,7 @@
EXPECT_EQ(webrtc::kVideoRotation_0, renderer_.rotation());
}
-TEST_F(VideoCapturerTest, TestRotationAppliedBySinkByDefault) {
+TEST_F(VideoCapturerTest, TestRotationAppliedBySink) {
int kWidth = 800;
int kHeight = 400;
@@ -168,6 +164,10 @@
cricket::FOURCC_I420));
capturer_->ResetSupportedFormats(formats);
+ rtc::VideoSinkWants wants;
+ // capturer_ should not compensate rotation.
+ wants.rotation_applied = false;
+ capturer_->AddOrUpdateSink(&renderer_, wants);
EXPECT_EQ(cricket::CS_RUNNING,
capturer_->Start(cricket::VideoFormat(
« no previous file with comments | « webrtc/media/base/videocapturer.cc ('k') | webrtc/media/base/videoframefactory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698