Detect and report camera close timeout.

Detect and report camera close timeout.

BUG=b/27677113
R=magjed@webrtc.org

Committed: https://crrev.com/56d4d059acb6007052b23e8049f35c95142df31f
Cr-Commit-Position: refs/heads/master@{#12043}

[AlexG, 2016-03-16 18:45:16]

glaznev@webrtc.org changed reviewers:
+ magjed@webrtc.org

[AlexG, 2016-03-16 18:45:17]

PTAL

[magjed_webrtc, 2016-03-17 12:05:45]

lgtm

https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/w...
File webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java (left):

https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:25: import
java.util.HashMap;
Thanks for the cleanup!

https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/w...
File webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:597: if
(!ThreadUtils.awaitUninterruptibly(barrier, CAMERA_STOP_TIMEOUT_MS)) {
I prefer 'if (!barrier.await(CAMERA_STOP_TIMEOUT_MS, TimeUnit.MILLISECONDS)) {'.
If you want to use ThreadUtils.awaitUninterruptibly(), remove 'throws
InterruptedException' from stopCapture().

https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:598: Logging.e(TAG,
"Camera stop timeout");
Call printStackTrace() here?

[AlexG, 2016-03-17 20:30:23]

https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/w...
File webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java (right):

https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:597: if
(!ThreadUtils.awaitUninterruptibly(barrier, CAMERA_STOP_TIMEOUT_MS)) {
On 2016/03/17 12:05:45, magjed_webrtc wrote:
> I prefer 'if (!barrier.await(CAMERA_STOP_TIMEOUT_MS, TimeUnit.MILLISECONDS))
{'.
> If you want to use ThreadUtils.awaitUninterruptibly(), remove 'throws
> InterruptedException' from stopCapture().

Done.

https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/w...
webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:598: Logging.e(TAG,
"Camera stop timeout");
On 2016/03/17 12:05:45, magjed_webrtc wrote:
> Call printStackTrace() here?

Done.

[AlexG, 2016-03-17 20:34:24]

The CQ bit was checked by glaznev@webrtc.org

[AlexG, 2016-03-17 20:34:24]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1801293004/#ps20001 (title:
"Address comments")

[commit-bot: I haz the power, 2016-03-17 20:34:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1801293004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1801293004/20001

[AlexG, 2016-03-17 22:15:06]

Description was changed from

==========
Detect and report camera close timeout.

BUG=b/27677113
==========

to

==========
Detect and report camera close timeout.

BUG=b/27677113
R=magjed@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/56d4d059acb6007052b23e804...
==========

[AlexG, 2016-03-17 22:15:08]

Committed patchset #2 (id:20001) manually as
56d4d059acb6007052b23e8049f35c95142df31f (presubmit successful).

[commit-bot: I haz the power, 2016-03-17 22:15:10]

Description was changed from

==========
Detect and report camera close timeout.

BUG=b/27677113
R=magjed@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/56d4d059acb6007052b23e804...
==========

to

==========
Detect and report camera close timeout.

BUG=b/27677113
R=magjed@webrtc.org

Committed: https://crrev.com/56d4d059acb6007052b23e8049f35c95142df31f
Cr-Commit-Position: refs/heads/master@{#12043}
==========

[commit-bot: I haz the power, 2016-03-17 22:15:11]

Patchset 2 (id:??) landed as
https://crrev.com/56d4d059acb6007052b23e8049f35c95142df31f
Cr-Commit-Position: refs/heads/master@{#12043}