Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1801293004: Detect and report camera close timeout. (Closed)

Created:
4 years, 9 months ago by AlexG
Modified:
4 years, 9 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Detect and report camera close timeout. BUG=b/27677113 R=magjed@webrtc.org Committed: https://crrev.com/56d4d059acb6007052b23e8049f35c95142df31f Cr-Commit-Position: refs/heads/master@{#12043}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 1 5 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
AlexG
PTAL
4 years, 9 months ago (2016-03-16 18:45:17 UTC) #2
magjed_webrtc
lgtm https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java File webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java (left): https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java#oldcode25 webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:25: import java.util.HashMap; Thanks for the cleanup! https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java File ...
4 years, 9 months ago (2016-03-17 12:05:45 UTC) #3
AlexG
https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java File webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java (right): https://codereview.webrtc.org/1801293004/diff/1/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java#newcode597 webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java:597: if (!ThreadUtils.awaitUninterruptibly(barrier, CAMERA_STOP_TIMEOUT_MS)) { On 2016/03/17 12:05:45, magjed_webrtc wrote: ...
4 years, 9 months ago (2016-03-17 20:30:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801293004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801293004/20001
4 years, 9 months ago (2016-03-17 20:34:29 UTC) #7
AlexG
Committed patchset #2 (id:20001) manually as 56d4d059acb6007052b23e8049f35c95142df31f (presubmit successful).
4 years, 9 months ago (2016-03-17 22:15:08 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 22:15:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/56d4d059acb6007052b23e8049f35c95142df31f
Cr-Commit-Position: refs/heads/master@{#12043}

Powered by Google App Engine
This is Rietveld 408576698