Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java

Issue 1801293004: Detect and report camera close timeout. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java
diff --git a/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java b/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java
index 1d19d179e64520e960b6c8259b48b8083f6b9e14..b8ab1a8c5ea6223ce46aebf7dae8a43e8fd21241 100644
--- a/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java
+++ b/webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java
@@ -21,12 +21,8 @@ import org.webrtc.Logging;
import java.io.IOException;
import java.nio.ByteBuffer;
-import java.util.ArrayList;
-import java.util.HashMap;
import java.util.HashSet;
-import java.util.IdentityHashMap;
import java.util.List;
-import java.util.Map;
import java.util.Set;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
@@ -50,6 +46,7 @@ public class VideoCapturerAndroid implements
private final static String TAG = "VideoCapturerAndroid";
private final static int CAMERA_OBSERVER_PERIOD_MS = 2000;
private final static int CAMERA_FREEZE_REPORT_TIMOUT_MS = 4000;
+ private static final int CAMERA_STOP_TIMEOUT_MS = 7000;
private boolean isDisposed = false;
private android.hardware.Camera camera; // Only non-null while capturing.
@@ -502,6 +499,11 @@ public class VideoCapturerAndroid implements
// Find closest supported format for |width| x |height| @ |framerate|.
final android.hardware.Camera.Parameters parameters = camera.getParameters();
+ for (int[] fpsRange : parameters.getSupportedPreviewFpsRange()) {
+ Logging.d(TAG, "Available fps range: " +
+ fpsRange[android.hardware.Camera.Parameters.PREVIEW_FPS_MIN_INDEX] + ":" +
+ fpsRange[android.hardware.Camera.Parameters.PREVIEW_FPS_MAX_INDEX]);
+ }
final int[] range = CameraEnumerationAndroid.getFramerateRange(parameters, framerate * 1000);
final android.hardware.Camera.Size previewSize =
CameraEnumerationAndroid.getClosestSupportedSize(
@@ -592,7 +594,13 @@ public class VideoCapturerAndroid implements
Logging.e(TAG, "Calling stopCapture() for already stopped camera.");
return;
}
- barrier.await();
+ if (!barrier.await(CAMERA_STOP_TIMEOUT_MS, TimeUnit.MILLISECONDS)) {
+ Logging.e(TAG, "Camera stop timeout");
+ printStackTrace();
+ if (eventsHandler != null) {
+ eventsHandler.onCameraError("Camera stop timeout");
+ }
+ }
Logging.d(TAG, "stopCapture done");
}
@@ -616,6 +624,7 @@ public class VideoCapturerAndroid implements
if (eventsHandler != null) {
eventsHandler.onCameraClosed();
}
+ Logging.d(TAG, "stopCaptureOnCameraThread done");
}
private void switchCameraOnCameraThread() {
« no previous file with comments | « webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698