Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1801233002: Revert opus memcheck suppression (Closed)

Created:
4 years, 9 months ago by flim-webrtc
Modified:
4 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert opus memcheck suppression BUG=https://bugs.chromium.org/p/webrtc/issues/detail?id=5651 Committed: https://crrev.com/f62d107aa7ad6fcf2bacec3c6eb4a16469ed2287 Cr-Commit-Position: refs/heads/master@{#12012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
stefan-webrtc
lgtm
4 years, 9 months ago (2016-03-16 09:28:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801233002/1
4 years, 9 months ago (2016-03-16 09:31:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 09:33:23 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f62d107aa7ad6fcf2bacec3c6eb4a16469ed2287 Cr-Commit-Position: refs/heads/master@{#12012}
4 years, 9 months ago (2016-03-16 09:33:31 UTC) #9
stefan-webrtc
4 years, 9 months ago (2016-03-16 14:43:21 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1807673004/ by stefan@webrtc.org.

The reason for reverting is: Reverting since the memcheck bot still fails..

Powered by Google App Engine
This is Rietveld 408576698