Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1800833002: Fixing flaky "TestExpireTime" test. (Closed)

Created:
4 years, 9 months ago by Taylor Brandstetter
Modified:
4 years, 9 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing flaky "TestExpireTime" test. It failed any time the clock ticked in between getting "now" and calling Generate. R=pthatcher@webrtc.org Committed: https://crrev.com/88dec8377814bc11bf3017beaa191a3cbd187c1e Cr-Commit-Position: refs/heads/master@{#12000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M webrtc/base/sslidentity_unittest.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Taylor Brandstetter
4 years, 9 months ago (2016-03-14 21:50:38 UTC) #2
pthatcher1
lgtm
4 years, 9 months ago (2016-03-15 04:01:06 UTC) #3
Taylor Brandstetter
Committed patchset #1 (id:1) manually as 88dec8377814bc11bf3017beaa191a3cbd187c1e (presubmit successful).
4 years, 9 months ago (2016-03-15 16:58:09 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 16:58:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88dec8377814bc11bf3017beaa191a3cbd187c1e
Cr-Commit-Position: refs/heads/master@{#12000}

Powered by Google App Engine
This is Rietveld 408576698