Fixing flaky "TestExpireTime" test.

webrtc/base/sslidentity_unittest.cc

 /*
  *  Copyright 2011 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 374 matching lines @@
       ASSERT_EQ(-1, res);
     }
   }
 
   void TestExpireTime(int times) {
     // We test just ECDSA here since what we're out to exercise is the
     // interfaces for expiration setting and reading.
     for (int i = 0; i < times; i++) {
       // We limit the time to < 2^31 here, i.e., we stay before 2038, since else
       // we hit time offset limitations in OpenSSL on some 32-bit systems.
-      time_t now = time(NULL);
-      time_t lifetime = rtc::CreateRandomId() % (0x80000000 - now);
+      time_t time_before_generation = time(nullptr);
+      time_t lifetime =
+          rtc::CreateRandomId() % (0x80000000 - time_before_generation);
       rtc::KeyParams key_params = rtc::KeyParams::ECDSA(rtc::EC_NIST_P256);
       SSLIdentity* identity =
           rtc::SSLIdentity::Generate("", key_params, lifetime);
-      EXPECT_EQ(now + lifetime,
+      time_t time_after_generation = time(nullptr);
+      EXPECT_LE(time_before_generation + lifetime,
+                identity->certificate().CertificateExpirationTime());
+      EXPECT_GE(time_after_generation + lifetime,
                 identity->certificate().CertificateExpirationTime());
       delete identity;
     }
   }
 };
 
 TEST_F(SSLIdentityExpirationTest, TestASN1TimeToSec) {
   TestASN1TimeToSec();
 }
 
 TEST_F(SSLIdentityExpirationTest, TestExpireTime) {
   TestExpireTime(500);
 }