Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: webrtc/base/sslstreamadapter_unittest.cc

Issue 1799233002: SSLCertificate::GetChain: Return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: No auto Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/sslidentity.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/sslstreamadapter_unittest.cc
diff --git a/webrtc/base/sslstreamadapter_unittest.cc b/webrtc/base/sslstreamadapter_unittest.cc
index 2eaa4753913d899404e4d5728ff10c07e03243aa..1e18b8305cc04f8699b22892252ec5d4058fa480 100644
--- a/webrtc/base/sslstreamadapter_unittest.cc
+++ b/webrtc/base/sslstreamadapter_unittest.cc
@@ -1056,8 +1056,7 @@ TEST_F(SSLStreamAdapterTestDTLSFromPEMStrings, TestDTLSGetPeerCertificate) {
ASSERT_NE(kCERT_PEM, client_peer_string);
// It must not have a chain, because the test certs are self-signed.
- rtc::SSLCertChain* client_peer_chain;
- ASSERT_FALSE(client_peer_cert->GetChain(&client_peer_chain));
+ ASSERT_FALSE(client_peer_cert->GetChain());
// The server should have a peer certificate after the handshake.
ASSERT_TRUE(GetPeerCertificate(false, server_peer_cert.accept()));
@@ -1067,8 +1066,7 @@ TEST_F(SSLStreamAdapterTestDTLSFromPEMStrings, TestDTLSGetPeerCertificate) {
ASSERT_EQ(kCERT_PEM, server_peer_cert->ToPEMString());
// It must not have a chain, because the test certs are self-signed.
- rtc::SSLCertChain* server_peer_chain;
- ASSERT_FALSE(server_peer_cert->GetChain(&server_peer_chain));
+ ASSERT_FALSE(server_peer_cert->GetChain());
}
// Test getting the used DTLS ciphers.
« no previous file with comments | « webrtc/base/sslidentity.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698