Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: webrtc/base/sslidentity.h

Issue 1799233002: SSLCertificate::GetChain: Return scoped_ptr (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: No auto Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/opensslidentity.cc ('k') | webrtc/base/sslstreamadapter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/sslidentity.h
diff --git a/webrtc/base/sslidentity.h b/webrtc/base/sslidentity.h
index 8793e4b2deb567e19dee9f0a1dfe9fe815a13e93..be0f3aa1076c031c99a341e16ff97aaad0bce42c 100644
--- a/webrtc/base/sslidentity.h
+++ b/webrtc/base/sslidentity.h
@@ -19,6 +19,7 @@
#include "webrtc/base/buffer.h"
#include "webrtc/base/messagedigest.h"
+#include "webrtc/base/scoped_ptr.h"
#include "webrtc/base/timeutils.h"
namespace rtc {
@@ -50,9 +51,9 @@ class SSLCertificate {
// Caller is responsible for freeing the returned object.
virtual SSLCertificate* GetReference() const = 0;
- // Provides the cert chain, or returns false. The caller owns the chain.
- // The chain includes a copy of each certificate, excluding the leaf.
- virtual bool GetChain(SSLCertChain** chain) const = 0;
+ // Provides the cert chain, or null. The chain includes a copy of each
+ // certificate, excluding the leaf.
+ virtual rtc::scoped_ptr<SSLCertChain> GetChain() const = 0;
// Returns a PEM encoded string representation of the certificate.
virtual std::string ToPEMString() const = 0;
« no previous file with comments | « webrtc/base/opensslidentity.cc ('k') | webrtc/base/sslstreamadapter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698