SSLCertificate::GetChain: Return scoped_ptr

SSLCertificate::GetChain: Return scoped_ptr

Instead of using a raw pointer output parameter. This is a good idea
in general, but will also be very convenient when scoped_ptr is gone,
since unique_ptr doesn't have an .accept() method.

BUG=webrtc:5520
Committed: https://crrev.com/f5d47860805e37a1e99a478ab7cd33a77ba9007b
Cr-Commit-Position: refs/heads/master@{#12004}

[kwiberg-webrtc, 2016-03-15 05:55:46]

kwiberg@webrtc.org changed reviewers:
+ tommi@webrtc.org, torbjorng@webrtc.org

[kwiberg-webrtc, 2016-03-15 05:55:47]

Do I need to provide backwards compatibility for out-of-tree callers? I've
compiled Chromium locally against this change without problems, but might there
be others who call this function?

[torbjorng (webrtc), 2016-03-15 09:12:40]

lgtm

(A code search suggests that the only caller in WebRTC/Chromium is in
webrtc/api/statscollector.cc.)

[tommi, 2016-03-15 09:26:55]

Can you check Chrome?

https://codereview.webrtc.org/1799233002/diff/1/webrtc/base/fakesslidentity.h
File webrtc/base/fakesslidentity.h (right):

https://codereview.webrtc.org/1799233002/diff/1/webrtc/base/fakesslidentity.h...
webrtc/base/fakesslidentity.h:76: auto chain = rtc::scoped_ptr<SSLCertChain>(new
SSLCertChain(new_certs));
Use of auto feels a bit forced here. Just use the full type and ctor syntax.

[kwiberg-webrtc, 2016-03-15 10:06:39]

https://codereview.webrtc.org/1799233002/diff/1/webrtc/base/fakesslidentity.h
File webrtc/base/fakesslidentity.h (right):

https://codereview.webrtc.org/1799233002/diff/1/webrtc/base/fakesslidentity.h...
webrtc/base/fakesslidentity.h:76: auto chain = rtc::scoped_ptr<SSLCertChain>(new
SSLCertChain(new_certs));
On 2016/03/15 09:26:55, tommi-webrtc wrote:
> Use of auto feels a bit forced here. Just use the full type and ctor syntax.

Right, that's actually shorter. Will do.

[kwiberg-webrtc, 2016-03-15 10:08:50]

On 2016/03/15 09:26:55, tommi-webrtc wrote:
> Can you check Chrome?

Already did. (I compiled Chrome on my machine (comment #2), and Torbjörn thought
of the cleverer test of just searching for the function name (comment #3).)

[tommi, 2016-03-15 15:27:05]

lgtm

[kwiberg-webrtc, 2016-03-15 18:08:09]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2016-03-15 18:08:09]

The patchset sent to the CQ was uploaded after l-g-t-m from torbjorng@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1799233002/#ps20001 (title:
"No auto")

[commit-bot: I haz the power, 2016-03-15 18:08:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799233002/20001

[commit-bot: I haz the power, 2016-03-15 19:53:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-15 19:53:37]

Description was changed from

==========
SSLCertificate::GetChain: Return scoped_ptr

Instead of using a raw pointer output parameter. This is a good idea
in general, but will also be very convenient when scoped_ptr is gone,
since unique_ptr doesn't have an .accept() method.

BUG=webrtc:5520
==========

to

==========
SSLCertificate::GetChain: Return scoped_ptr

Instead of using a raw pointer output parameter. This is a good idea
in general, but will also be very convenient when scoped_ptr is gone,
since unique_ptr doesn't have an .accept() method.

BUG=webrtc:5520

Committed: https://crrev.com/f5d47860805e37a1e99a478ab7cd33a77ba9007b
Cr-Commit-Position: refs/heads/master@{#12004}
==========

[commit-bot: I haz the power, 2016-03-15 19:53:38]

Patchset 2 (id:??) landed as
https://crrev.com/f5d47860805e37a1e99a478ab7cd33a77ba9007b
Cr-Commit-Position: refs/heads/master@{#12004}