Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1796183002: Remove unused method OutputMixer::PlayDtmfTone() and infrastructure. (Closed)

Created:
4 years, 9 months ago by the sun
Modified:
4 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@voe_dtmf_6
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused method OutputMixer::PlayDtmfTone() and infrastructure. BUG=webrtc:4690 Committed: https://crrev.com/e50872be1389b5e5e9967ee530a355d6ff5ea293 Cr-Commit-Position: refs/heads/master@{#11990}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -563 lines) Patch
M webrtc/voice_engine/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/voice_engine/dtmf_inband.h View 1 chunk +0 lines, -90 lines 0 comments Download
D webrtc/voice_engine/dtmf_inband.cc View 1 chunk +0 lines, -389 lines 0 comments Download
M webrtc/voice_engine/include/voe_errors.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/output_mixer.h View 4 chunks +0 lines, -6 lines 0 comments Download
M webrtc/voice_engine/output_mixer.cc View 5 chunks +0 lines, -73 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1804523002 Patch 100001

Messages

Total messages: 12 (5 generated)
the sun
4 years, 9 months ago (2016-03-14 15:07:11 UTC) #2
hlundin-webrtc
lgtm
4 years, 9 months ago (2016-03-14 15:17:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796183002/20001
4 years, 9 months ago (2016-03-14 19:16:39 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) ...
4 years, 9 months ago (2016-03-14 21:17:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796183002/20001
4 years, 9 months ago (2016-03-14 21:27:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-14 22:32:53 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 22:32:59 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e50872be1389b5e5e9967ee530a355d6ff5ea293
Cr-Commit-Position: refs/heads/master@{#11990}

Powered by Google App Engine
This is Rietveld 408576698