Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1804523002: Relanding https://codereview.webrtc.org/1715883002/ in pieces. (Closed)

Created:
4 years, 9 months ago by the sun
Modified:
4 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Relanding https://codereview.webrtc.org/1715883002/ in pieces. - Remove unused callback OnPlayTelephoneEvent from voe::Channel. BUG=webrtc:4690 Committed: https://crrev.com/1122dc0d9b069d4ce7d79daacd39c3606c358838 Cr-Commit-Position: refs/heads/master@{#11984}

Patch Set 1 #

Patch Set 2 : revert dtmfsender_unittest #

Patch Set 3 : strip out code in OnPlayTelephoneEvent #

Patch Set 4 : rebase #

Patch Set 5 : bad merge #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M webrtc/voice_engine/channel.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 3 4 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
the sun
4 years, 9 months ago (2016-03-14 13:30:58 UTC) #2
hlundin-webrtc
lgtm
4 years, 9 months ago (2016-03-14 14:58:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804523002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804523002/100001
4 years, 9 months ago (2016-03-14 15:05:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804523002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804523002/120001
4 years, 9 months ago (2016-03-14 15:24:15 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-14 18:52:28 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 18:52:39 UTC) #11
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/1122dc0d9b069d4ce7d79daacd39c3606c358838
Cr-Commit-Position: refs/heads/master@{#11984}

Powered by Google App Engine
This is Rietveld 408576698