Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1792613002: Revert of Safe numeric library: base/numerics (copied from Chromium) (Closed)

Created:
4 years, 9 months ago by tommi
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Safe numeric library: base/numerics (copied from Chromium) (patchset #11 id:250001 of https://codereview.webrtc.org/1753293002/ ) Reason for revert: Looks like the Chrome iOS build is broken because of these two changes. So I'm going to have to revert. Here's the error: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/185624/steps/compile/logs/stdio FAILED: rm -f arch/libsafe_numerics.arm64.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.arm64.a error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols] Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load] FAILED: rm -f arch/libsafe_numerics.armv7.a && ./gyp-mac-tool filter-libtool libtool -static -o arch/libsafe_numerics.armv7.a error: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no files specified Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-sacLT] [-no_warning_for_no_symbols] Usage: /Applications/Xcode7.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -dynamic [-] file [...] [-filelist listfile[,dirname]] [-arch_only arch] [-o output] [-install_name name] [-compatibility_version #] [-current_version #] [-seg1addr 0x#] [-segs_read_only_addr 0x#] [-segs_read_write_addr 0x#] [-seg_addr_table <filename>] [-seg_addr_table_filename <file_system_path>] [-all_load] [-noall_load] ninja: build stopped: subcommand failed. Original issue's description: > Safe numeric library added: base/numerics (copied from Chromium) > > This copies the contents (unittest excluded) of base/numerics in > chromium to base/numerics in webrtc. Files added: > - safe_conversions.h > - safe_conversions_impl.h > - safe_math.h > - safe_math_impl.h > > A really old version of safe_conversions[_impl].h previously existed in > base/, this has been deleted and sources using it have been updated > to include the new base/numerics/safe_converions.h. > > This CL also adds a DEPS file to webrtc/base. > > NOPRESUBMIT=True > BUG=webrtc:5548, webrtc:5623 > > Committed: https://crrev.com/de1c81b2d2196be611674aa6019b9db3a9329042 > Cr-Commit-Position: refs/heads/master@{#11907} TBR=kjellander@webrtc.org,kwiberg@webrtc.org,tina.legrand@webrtc.org,hbos@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5548, webrtc:5623 Committed: https://crrev.com/d44c077dce713cf350308f599053ee5b551d0bf5 Cr-Commit-Position: refs/heads/master@{#11965}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -1380 lines) Patch
M webrtc/base/BUILD.gn View 4 chunks +6 lines, -20 lines 0 comments Download
D webrtc/base/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/base/base.gyp View 4 chunks +4 lines, -15 lines 0 comments Download
D webrtc/base/numerics/safe_conversions.h View 1 chunk +0 lines, -175 lines 0 comments Download
D webrtc/base/numerics/safe_conversions_impl.h View 1 chunk +0 lines, -273 lines 0 comments Download
D webrtc/base/numerics/safe_math.h View 1 chunk +0 lines, -312 lines 0 comments Download
D webrtc/base/numerics/safe_math_impl.h View 1 chunk +0 lines, -556 lines 0 comments Download
M webrtc/base/openssladapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/rtccertificate_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/base/safe_conversions.h View 1 chunk +70 lines, -0 lines 0 comments Download
A webrtc/base/safe_conversions_impl.h View 1 chunk +188 lines, -0 lines 0 comments Download
M webrtc/common_audio/audio_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/wav_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/sctp/sctpdataengine.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/delay_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/expand.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/expand_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/statistics_calculator.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/time_stretch.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing_performance_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tommi
Created Revert of Safe numeric library: base/numerics (copied from Chromium)
4 years, 9 months ago (2016-03-12 01:00:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792613002/1
4 years, 9 months ago (2016-03-12 01:00:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1792613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1792613002/1
4 years, 9 months ago (2016-03-12 01:01:46 UTC) #3
tommi
Committed patchset #1 (id:1) manually as d44c077dce713cf350308f599053ee5b551d0bf5 (presubmit successful).
4 years, 9 months ago (2016-03-12 01:12:46 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 01:12:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d44c077dce713cf350308f599053ee5b551d0bf5
Cr-Commit-Position: refs/heads/master@{#11965}

Powered by Google App Engine
This is Rietveld 408576698