Replace scoped_ptr with unique_ptr in webrtc/call/

Replace scoped_ptr with unique_ptr in webrtc/call/

BUG=webrtc:5520
Committed: https://crrev.com/b25345ee3f2f27a6814495f7f617f954fb4b192a
Cr-Commit-Position: refs/heads/master@{#11970}

[kwiberg-webrtc, 2016-03-12 10:50:55]

kwiberg@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[the sun, 2016-03-12 11:51:13]

lgtm

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc
File webrtc/call/rtc_event_log.cc (right):

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc#...
webrtc/call/rtc_event_log.cc:109:
std::unique_ptr<FileWrapper>(FileWrapper::Create());
Is make_unique() C++14 or C++17?

[stefan-webrtc, 2016-03-12 12:05:17]

stefan@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-03-12 12:05:18]

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/bitrate_allocator.h
File webrtc/call/bitrate_allocator.h (right):

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/bitrate_allocator...
webrtc/call/bitrate_allocator.h:14: #include <stdint.h>
webrtc/typedefs.h

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc
File webrtc/call/rtc_event_log.cc (right):

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc#...
webrtc/call/rtc_event_log.cc:176: : file_(FileWrapper::Create()),
You may not have the answer, but it seems odd to me that the file wrapper is
created here and on line 109... Maybe you can remove one of them? Preferably
line 109 since we already get the clock in the initializer list.

[kwiberg-webrtc, 2016-03-12 14:06:46]

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/bitrate_allocator.h
File webrtc/call/bitrate_allocator.h (right):

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/bitrate_allocator...
webrtc/call/bitrate_allocator.h:14: #include <stdint.h>
On 2016/03/12 12:05:18, stefan-webrtc (holmer) wrote:
> webrtc/typedefs.h

Why? It just #includes stdint.h, and has a bunch of stuff I don’t want. (It also
has a comment that it should be #including webrtc/base/basictypes.h instead, but
that one also just #includes stdint.h and has a bunch of stuff I don’t want.)

And I didn’t even look that up before choosing stdint.h, even though I
remembered we had some header file for it. Because either our header file
defines the integer types in a manner compatible with stdint.h, in which case it
doesn't matter, or else we have a major problem because there are a thousand
places where an #include of stdint.h could creep in and wreak havoc.

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc
File webrtc/call/rtc_event_log.cc (right):

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc#...
webrtc/call/rtc_event_log.cc:109:
std::unique_ptr<FileWrapper>(FileWrapper::Create());
On 2016/03/12 11:51:13, the sun wrote:
> Is make_unique() C++14 or C++17?

C++14. Although it wouldn't be of any use here, would it? auto, on the other
hand, would have been.

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc#...
webrtc/call/rtc_event_log.cc:176: : file_(FileWrapper::Create()),
On 2016/03/12 12:05:18, stefan-webrtc (holmer) wrote:
> You may not have the answer, but it seems odd to me that the file wrapper is
> created here and on line 109... Maybe you can remove one of them? Preferably
> line 109 since we already get the clock in the initializer list.

I don’t want to do it in this CL. It’s the Unix philosophy of CLs: “do only one
thing, but do it well”.

But yes, one of them should probably go away. I don’t think we actually end up
executing more than one of them, though, so it’s just a code neatness issue.

[kwiberg-webrtc, 2016-03-12 14:07:02]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-03-12 14:07:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1789903003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1789903003/1

[kwiberg-webrtc, 2016-03-12 14:10:05]

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc
File webrtc/call/rtc_event_log.cc (right):

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc#...
webrtc/call/rtc_event_log.cc:109:
std::unique_ptr<FileWrapper>(FileWrapper::Create());
On 2016/03/12 14:06:46, kwiberg-webrtc wrote:
> On 2016/03/12 11:51:13, the sun wrote:
> > Is make_unique() C++14 or C++17?
> 
> C++14. Although it wouldn't be of any use here, would it? auto, on the other
> hand, would have been.

No, auto can’t be used here. This is a class definition.

[commit-bot: I haz the power, 2016-03-12 14:10:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-12 14:11:01]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/call/

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/call/

BUG=webrtc:5520

Committed: https://crrev.com/b25345ee3f2f27a6814495f7f617f954fb4b192a
Cr-Commit-Position: refs/heads/master@{#11970}
==========

[commit-bot: I haz the power, 2016-03-12 14:11:02]

Patchset 1 (id:??) landed as
https://crrev.com/b25345ee3f2f27a6814495f7f617f954fb4b192a
Cr-Commit-Position: refs/heads/master@{#11970}

[stefan-webrtc, 2016-03-12 14:42:39]

lgtm

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/bitrate_allocator.h
File webrtc/call/bitrate_allocator.h (right):

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/bitrate_allocator...
webrtc/call/bitrate_allocator.h:14: #include <stdint.h>
On 2016/03/12 14:06:46, kwiberg-webrtc wrote:
> On 2016/03/12 12:05:18, stefan-webrtc (holmer) wrote:
> > webrtc/typedefs.h
> 
> Why? It just #includes stdint.h, and has a bunch of stuff I don’t want. (It
also
> has a comment that it should be #including webrtc/base/basictypes.h instead,
but
> that one also just #includes stdint.h and has a bunch of stuff I don’t want.)
> 
> And I didn’t even look that up before choosing stdint.h, even though I
> remembered we had some header file for it. Because either our header file
> defines the integer types in a manner compatible with stdint.h, in which case
it
> doesn't matter, or else we have a major problem because there are a thousand
> places where an #include of stdint.h could creep in and wreak havoc.

Ok, I don't know the details of why we use typedefs.h, isn't clear to me if it
does something different from stdint.h, so if you are convinced go ahead. :) I
was mostly thinking about following the convension.

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc
File webrtc/call/rtc_event_log.cc (right):

https://codereview.webrtc.org/1789903003/diff/1/webrtc/call/rtc_event_log.cc#...
webrtc/call/rtc_event_log.cc:176: : file_(FileWrapper::Create()),
On 2016/03/12 14:06:46, kwiberg-webrtc wrote:
> On 2016/03/12 12:05:18, stefan-webrtc (holmer) wrote:
> > You may not have the answer, but it seems odd to me that the file wrapper is
> > created here and on line 109... Maybe you can remove one of them? Preferably
> > line 109 since we already get the clock in the initializer list.
> 
> I don’t want to do it in this CL. It’s the Unix philosophy of CLs: “do only
one
> thing, but do it well”.
> 
> But yes, one of them should probably go away. I don’t think we actually end up
> executing more than one of them, though, so it’s just a code neatness issue.

Sure, no problem. I was just surprised when I reviewed... One of the downsides
with having to places to initialize things, IMO.