Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: webrtc/call/bitrate_allocator.h

Issue 1789903003: Replace scoped_ptr with unique_ptr in webrtc/call/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/call/bitrate_allocator_unittest.cc » ('j') | webrtc/call/rtc_event_log.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_CALL_BITRATE_ALLOCATOR_H_ 11 #ifndef WEBRTC_CALL_BITRATE_ALLOCATOR_H_
12 #define WEBRTC_CALL_BITRATE_ALLOCATOR_H_ 12 #define WEBRTC_CALL_BITRATE_ALLOCATOR_H_
13 13
14 #include <stdint.h>
stefan-webrtc 2016/03/12 12:05:18 webrtc/typedefs.h
kwiberg-webrtc 2016/03/12 14:06:46 Why? It just #includes stdint.h, and has a bunch o
stefan-webrtc 2016/03/12 14:42:39 Ok, I don't know the details of why we use typedef
15
14 #include <list> 16 #include <list>
15 #include <map> 17 #include <map>
16 #include <utility> 18 #include <utility>
17 19
18 #include "webrtc/base/criticalsection.h" 20 #include "webrtc/base/criticalsection.h"
19 #include "webrtc/base/scoped_ptr.h"
20 #include "webrtc/base/thread_annotations.h" 21 #include "webrtc/base/thread_annotations.h"
21 22
22 namespace webrtc { 23 namespace webrtc {
23 24
24 // Used by all send streams with adaptive bitrate, to get the currently 25 // Used by all send streams with adaptive bitrate, to get the currently
25 // allocated bitrate for the send stream. The current network properties are 26 // allocated bitrate for the send stream. The current network properties are
26 // given at the same time, to let the send stream decide about possible loss 27 // given at the same time, to let the send stream decide about possible loss
27 // protection. 28 // protection.
28 class BitrateAllocatorObserver { 29 class BitrateAllocatorObserver {
29 public: 30 public:
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 // Stored in a list to keep track of the insertion order. 104 // Stored in a list to keep track of the insertion order.
104 BitrateObserverConfList bitrate_observers_ GUARDED_BY(crit_sect_); 105 BitrateObserverConfList bitrate_observers_ GUARDED_BY(crit_sect_);
105 bool bitrate_observers_modified_ GUARDED_BY(crit_sect_); 106 bool bitrate_observers_modified_ GUARDED_BY(crit_sect_);
106 bool enforce_min_bitrate_ GUARDED_BY(crit_sect_); 107 bool enforce_min_bitrate_ GUARDED_BY(crit_sect_);
107 uint32_t last_bitrate_bps_ GUARDED_BY(crit_sect_); 108 uint32_t last_bitrate_bps_ GUARDED_BY(crit_sect_);
108 uint8_t last_fraction_loss_ GUARDED_BY(crit_sect_); 109 uint8_t last_fraction_loss_ GUARDED_BY(crit_sect_);
109 int64_t last_rtt_ GUARDED_BY(crit_sect_); 110 int64_t last_rtt_ GUARDED_BY(crit_sect_);
110 }; 111 };
111 } // namespace webrtc 112 } // namespace webrtc
112 #endif // WEBRTC_CALL_BITRATE_ALLOCATOR_H_ 113 #endif // WEBRTC_CALL_BITRATE_ALLOCATOR_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/call/bitrate_allocator_unittest.cc » ('j') | webrtc/call/rtc_event_log.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698