Update examples GYP to avoid rtc_base_approved warning.

webrtc/base/BUILD.gn

Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index b4d14fc6d13c6cb66976e858b070732ee44fc61e..33c49ece13855ade2c040e3b7172d34767675ff2 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -116,6 +116,8 @@ static_library("rtc_base_approved") {
     "byteorder.h",
     "checks.cc",
     "checks.h",
+    "common.cc",

[tommi, 2016/03/11 06:43:46]

I would prefer not to add common.h and .cc to base_approved because they add
ASSERT and VERIFY whereas we already have DCHECK and CHECK in base_approved. 
There are furthermore some logging related things and variables that I don't
think we need.  If we can instead update the sample to use what's already in
base_approved, that would be preferable.

[tkchin_webrtc, 2016/03/12 00:56:15]

Thanks - I'll look into that.

+    "common.h",
     "constructormagic.h",
     "criticalsection.cc",
     "criticalsection.h",
@@ -126,6 +128,8 @@ static_library("rtc_base_approved") {
     "event_tracer.h",
     "exp_filter.cc",
     "exp_filter.h",
+    "flags.cc",

[tommi, 2016/03/11 06:43:46]

flags also seems something marginal to base, so I'd rather want to reconsider
its use in the sample and be a bit strict about what we add to base_approved.

[tkchin_webrtc, 2016/03/12 00:56:15]

I found command_line_parser in webrtc/tools.

+    "flags.h",
     "md5.cc",
     "md5.h",
     "md5digest.cc",
@@ -157,6 +161,8 @@ static_library("rtc_base_approved") {
     "timeutils.cc",
     "timeutils.h",
     "trace_event.h",
+    "urlencode.cc",

[tommi, 2016/03/11 06:43:46]

urlencode seems to be fine except it has a dependency on common.h.  Can we clean
that up?

alternatively:
- are there perhaps some alternatives already available in base that the sample
could use instead?
- Is urlencode.h depended upon by webrtc production code? (is it only the
sample?)

[tkchin_webrtc, 2016/03/12 00:56:15]

It's only in the peer_channel example for webrtc, and compiled in
libjingle_nacl.gyp. I don't see it being used in chromium though.
stringencode.h has replacement functions.

+    "urlencode.h",
   ]
 
   if (build_with_chromium) {
@@ -220,8 +226,6 @@ static_library("rtc_base") {
     "autodetectproxy.h",
     "base64.cc",
     "base64.h",
-    "common.cc",
-    "common.h",
     "copyonwritebuffer.cc",
     "copyonwritebuffer.h",
     "crc32.cc",
@@ -236,8 +240,6 @@ static_library("rtc_base") {
     "fileutils.h",
     "firewallsocketserver.cc",
     "firewallsocketserver.h",
-    "flags.cc",
-    "flags.h",
     "format_macros.h",
     "gunit_prod.h",
     "helpers.cc",
@@ -333,8 +335,6 @@ static_library("rtc_base") {
     "thread.h",
     "timing.cc",
     "timing.h",
-    "urlencode.cc",
-    "urlencode.h",
     "worker.cc",
     "worker.h",
   ]