Update examples GYP to avoid rtc_base_approved warning.

webrtc/base/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/crypto.gni")
 import("//build/config/ui.gni")
@@ skipping 98 matching lines @@
     "bitbuffer.h",
     "buffer.cc",
     "buffer.h",
     "bufferqueue.cc",
     "bufferqueue.h",
     "bytebuffer.cc",
     "bytebuffer.h",
     "byteorder.h",
     "checks.cc",
     "checks.h",
+    "common.cc",

[tommi, 2016/03/11 06:43:46]

I would prefer not to add common.h and .cc to base_approved because they add
ASSERT and VERIFY whereas we already have DCHECK and CHECK in base_approved. 
There are furthermore some logging related things and variables that I don't
think we need.  If we can instead update the sample to use what's already in
base_approved, that would be preferable.

[tkchin_webrtc, 2016/03/12 00:56:15]

Thanks - I'll look into that.

+    "common.h",
     "constructormagic.h",
     "criticalsection.cc",
     "criticalsection.h",
     "deprecation.h",
     "event.cc",
     "event.h",
     "event_tracer.cc",
     "event_tracer.h",
     "exp_filter.cc",
     "exp_filter.h",
+    "flags.cc",

[tommi, 2016/03/11 06:43:46]

flags also seems something marginal to base, so I'd rather want to reconsider
its use in the sample and be a bit strict about what we add to base_approved.

[tkchin_webrtc, 2016/03/12 00:56:15]

I found command_line_parser in webrtc/tools.

+    "flags.h",
     "md5.cc",
     "md5.h",
     "md5digest.cc",
     "md5digest.h",
     "optional.h",
     "platform_file.cc",
     "platform_file.h",
     "platform_thread.cc",
     "platform_thread.h",
     "platform_thread_types.h",
@@ skipping 11 matching lines @@
     "systeminfo.cc",
     "systeminfo.h",
     "template_util.h",
     "thread_annotations.h",
     "thread_checker.h",
     "thread_checker_impl.cc",
     "thread_checker_impl.h",
     "timeutils.cc",
     "timeutils.h",
     "trace_event.h",
+    "urlencode.cc",

[tommi, 2016/03/11 06:43:46]

urlencode seems to be fine except it has a dependency on common.h.  Can we clean
that up?

alternatively:
- are there perhaps some alternatives already available in base that the sample
could use instead?
- Is urlencode.h depended upon by webrtc production code? (is it only the
sample?)

[tkchin_webrtc, 2016/03/12 00:56:15]

It's only in the peer_channel example for webrtc, and compiled in
libjingle_nacl.gyp. I don't see it being used in chromium though.
stringencode.h has replacement functions.

+    "urlencode.h",
   ]
 
   if (build_with_chromium) {
     # Dependency on chromium's logging (in //base).
     deps += [ "//base:base" ]
     sources += [
       "../../webrtc_overrides/webrtc/base/logging.cc",
       "../../webrtc_overrides/webrtc/base/logging.h",
     ]
     include_dirs = [ "../../webrtc_overrides" ]
@@ skipping 43 matching lines @@
     "asyncsocket.cc",
     "asyncsocket.h",
     "asynctcpsocket.cc",
     "asynctcpsocket.h",
     "asyncudpsocket.cc",
     "asyncudpsocket.h",
     "autodetectproxy.cc",
     "autodetectproxy.h",
     "base64.cc",
     "base64.h",
-    "common.cc",
-    "common.h",
     "copyonwritebuffer.cc",
     "copyonwritebuffer.h",
     "crc32.cc",
     "crc32.h",
     "cryptstring.cc",
     "cryptstring.h",
     "diskcache.cc",
     "diskcache.h",
     "filerotatingstream.cc",
     "filerotatingstream.h",
     "fileutils.cc",
     "fileutils.h",
     "firewallsocketserver.cc",
     "firewallsocketserver.h",
-    "flags.cc",
-    "flags.h",
     "format_macros.h",
     "gunit_prod.h",
     "helpers.cc",
     "helpers.h",
     "httpbase.cc",
     "httpbase.h",
     "httpclient.cc",
     "httpclient.h",
     "httpcommon-inl.h",
     "httpcommon.cc",
@@ skipping 75 matching lines @@
     "task.cc",
     "task.h",
     "taskparent.cc",
     "taskparent.h",
     "taskrunner.cc",
     "taskrunner.h",
     "thread.cc",
     "thread.h",
     "timing.cc",
     "timing.h",
-    "urlencode.cc",
-    "urlencode.h",
     "worker.cc",
     "worker.h",
   ]
 
   if (is_posix) {
     sources += [
       "ifaddrs-android.h",
       "ifaddrs_converter.cc",
       "unixfilesystem.cc",
       "unixfilesystem.h",
@@ skipping 318 matching lines @@
   deps = [
     ":rtc_base_approved",
   ]
   sources = [
     "numerics/safe_conversions.h",
     "numerics/safe_conversions_impl.h",
     "numerics/safe_math.h",
     "numerics/safe_math_impl.h",
   ]
 }