Update examples GYP to avoid rtc_base_approved warning.

Update examples GYP to avoid rtc_base_approved warning.

Updated peerconnection_server to not need stuff from rtc_base.

BUG=

Committed: https://crrev.com/bad7b091af061dfb6fe69ef6331715b48329200d
Cr-Commit-Position: refs/heads/master@{#11966}

[tkchin_webrtc, 2016-03-11 03:30:39]

Patchset #1 (id:1) has been deleted

[tkchin_webrtc, 2016-03-11 03:30:46]

Patchset #1 (id:20001) has been deleted

[tkchin_webrtc, 2016-03-11 03:33:08]

Description was changed from

==========
Update examples GYP to avoid rtc_base_approved warning.

BUG=
==========

to

==========
Update examples GYP to avoid rtc_base_approved warning.

BUG=
==========

[tkchin_webrtc, 2016-03-11 03:33:08]

tkchin@webrtc.org changed reviewers:
+ kjellander@webrtc.org, tommi@webrtc.org

[tkchin_webrtc, 2016-03-11 03:34:55]

Description was changed from

==========
Update examples GYP to avoid rtc_base_approved warning.

BUG=
==========

to

==========
Update examples GYP to avoid rtc_base_approved warning.

Some files needed to be moved to rtc_base_approved because
the peerconnection_server target depended on them.

BUG=
==========

[tkchin_webrtc, 2016-03-11 03:35:33]

Patchset #1 (id:40001) has been deleted

[tkchin_webrtc, 2016-03-11 03:41:20]

Currently the presubmit script yells at me for making changes to
webrtc_examples.gyp because some targets depend on rtc_base instead of
rtc_base_approved. I moved their dependencies to rtc_base_approved, but I'm not
exactly sure what passes the requirement to be in rtc_base_approved. tommi@ can
you comment?

[kjellander_webrtc, 2016-03-11 04:43:24]

On 2016/03/11 03:41:20, tkchin_webrtc wrote:
> Currently the presubmit script yells at me for making changes to
> webrtc_examples.gyp because some targets depend on rtc_base instead of
> rtc_base_approved. I moved their dependencies to rtc_base_approved, but I'm
not
> exactly sure what passes the requirement to be in rtc_base_approved. tommi@
can
> you comment?

See https://bugs.chromium.org/p/webrtc/issues/detail?id=3806 for that context.

[kjellander_webrtc, 2016-03-11 04:44:43]

On 2016/03/11 04:43:24, kjellander (webrtc) wrote:
> On 2016/03/11 03:41:20, tkchin_webrtc wrote:
> > Currently the presubmit script yells at me for making changes to
> > webrtc_examples.gyp because some targets depend on rtc_base instead of
> > rtc_base_approved. I moved their dependencies to rtc_base_approved, but I'm
> not
> > exactly sure what passes the requirement to be in rtc_base_approved. tommi@
> can
> > you comment?
> 
> See https://bugs.chromium.org/p/webrtc/issues/detail?id=3806 for that context.

Chrome infra pushed a bad change causing the winbots to fail., please just retry
since it's now been reverted.

[tommi, 2016-03-11 06:43:47]

https://codereview.webrtc.org/1789463002/diff/60001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/1789463002/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:119: "common.cc",
I would prefer not to add common.h and .cc to base_approved because they add
ASSERT and VERIFY whereas we already have DCHECK and CHECK in base_approved. 
There are furthermore some logging related things and variables that I don't
think we need.  If we can instead update the sample to use what's already in
base_approved, that would be preferable.

https://codereview.webrtc.org/1789463002/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:131: "flags.cc",
flags also seems something marginal to base, so I'd rather want to reconsider
its use in the sample and be a bit strict about what we add to base_approved.

https://codereview.webrtc.org/1789463002/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:164: "urlencode.cc",
urlencode seems to be fine except it has a dependency on common.h.  Can we clean
that up?

alternatively:
- are there perhaps some alternatives already available in base that the sample
could use instead?
- Is urlencode.h depended upon by webrtc production code? (is it only the
sample?)

[tkchin_webrtc, 2016-03-12 00:56:15]

PTAL

I tried out the server. It seems to not work quite as expected (some stuff on
the test web page doesn't work for sending messages to other connected clients).
But that's true before and after the change, and clients are able to connect.

https://codereview.webrtc.org/1789463002/diff/60001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/1789463002/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:119: "common.cc",
On 2016/03/11 06:43:46, tommi-webrtc wrote:
> I would prefer not to add common.h and .cc to base_approved because they add
> ASSERT and VERIFY whereas we already have DCHECK and CHECK in base_approved. 
> There are furthermore some logging related things and variables that I don't
> think we need.  If we can instead update the sample to use what's already in
> base_approved, that would be preferable.

Thanks - I'll look into that.

https://codereview.webrtc.org/1789463002/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:131: "flags.cc",
On 2016/03/11 06:43:46, tommi-webrtc wrote:
> flags also seems something marginal to base, so I'd rather want to reconsider
> its use in the sample and be a bit strict about what we add to base_approved.

I found command_line_parser in webrtc/tools.

https://codereview.webrtc.org/1789463002/diff/60001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:164: "urlencode.cc",
On 2016/03/11 06:43:46, tommi-webrtc wrote:
> urlencode seems to be fine except it has a dependency on common.h.  Can we
clean
> that up?
> 
> alternatively:
> - are there perhaps some alternatives already available in base that the
sample
> could use instead?
> - Is urlencode.h depended upon by webrtc production code? (is it only the
> sample?)

It's only in the peer_channel example for webrtc, and compiled in
libjingle_nacl.gyp. I don't see it being used in chromium though.
stringencode.h has replacement functions.

[tkchin_webrtc, 2016-03-12 01:49:11]

tkchin@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2016-03-12 01:52:58]

lgtm

[tkchin_webrtc, 2016-03-12 01:54:03]

Description was changed from

==========
Update examples GYP to avoid rtc_base_approved warning.

Some files needed to be moved to rtc_base_approved because
the peerconnection_server target depended on them.

BUG=
==========

to

==========
Update examples GYP to avoid rtc_base_approved warning.

Updated peerconnection_server to not need stuff from rtc_base.

BUG=
==========

[tkchin_webrtc, 2016-03-12 01:54:52]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2016-03-12 01:54:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1789463002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1789463002/120001

[commit-bot: I haz the power, 2016-03-12 03:01:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-12 03:01:32]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kjellander_webrtc, 2016-03-12 04:43:56]

The CQ bit was checked by kjellander@webrtc.org

[commit-bot: I haz the power, 2016-03-12 04:44:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1789463002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1789463002/120001

[commit-bot: I haz the power, 2016-03-12 04:45:20]

Description was changed from

==========
Update examples GYP to avoid rtc_base_approved warning.

Updated peerconnection_server to not need stuff from rtc_base.

BUG=
==========

to

==========
Update examples GYP to avoid rtc_base_approved warning.

Updated peerconnection_server to not need stuff from rtc_base.

BUG=
==========

[commit-bot: I haz the power, 2016-03-12 04:45:21]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-03-12 04:45:32]

Description was changed from

==========
Update examples GYP to avoid rtc_base_approved warning.

Updated peerconnection_server to not need stuff from rtc_base.

BUG=
==========

to

==========
Update examples GYP to avoid rtc_base_approved warning.

Updated peerconnection_server to not need stuff from rtc_base.

BUG=

Committed: https://crrev.com/bad7b091af061dfb6fe69ef6331715b48329200d
Cr-Commit-Position: refs/heads/master@{#11966}
==========

[commit-bot: I haz the power, 2016-03-12 04:45:33]

Patchset 4 (id:??) landed as
https://crrev.com/bad7b091af061dfb6fe69ef6331715b48329200d
Cr-Commit-Position: refs/heads/master@{#11966}