Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1785173002: Replace scoped_ptr with unique_ptr in webrtc/modules/ (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, kwiberg-webrtc, zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@up8
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/ Except in places where this would break out-of-tree code, such as Chromium. BUG=webrtc:5520 Committed: https://crrev.com/22feaa3d15881c659d8fe1b49441649c0396d6a1 Cr-Commit-Position: refs/heads/master@{#12037}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -37 lines) Patch
M webrtc/modules/audio_coding/acm2/rent_a_codec_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/pacing/packet_router.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/pacing/packet_router_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/include/mock/mock_process_thread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/utility/source/coder.h View 2 chunks +3 lines, -2 lines 2 comments Download
M webrtc/modules/utility/source/helpers_ios.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 8 chunks +11 lines, -10 lines 0 comments Download
M webrtc/modules/video_coding/nack_module_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-17 12:43:25 UTC) #3
tommi
lgtm https://codereview.webrtc.org/1785173002/diff/60001/webrtc/modules/utility/source/coder.h File webrtc/modules/utility/source/coder.h (right): https://codereview.webrtc.org/1785173002/diff/60001/webrtc/modules/utility/source/coder.h#newcode50 webrtc/modules/utility/source/coder.h:50: std::unique_ptr<AudioCodingModule> _acm; fix indent? (seems like it was ...
4 years, 9 months ago (2016-03-17 12:58:36 UTC) #4
kwiberg-webrtc
https://codereview.webrtc.org/1785173002/diff/60001/webrtc/modules/utility/source/coder.h File webrtc/modules/utility/source/coder.h (right): https://codereview.webrtc.org/1785173002/diff/60001/webrtc/modules/utility/source/coder.h#newcode50 webrtc/modules/utility/source/coder.h:50: std::unique_ptr<AudioCodingModule> _acm; On 2016/03/17 12:58:36, tommi-webrtc wrote: > fix ...
4 years, 9 months ago (2016-03-17 13:06:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785173002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785173002/60001
4 years, 9 months ago (2016-03-17 13:07:36 UTC) #10
tommi
fine - lgtm stands. I'm also fine with not worrying about it at all now.
4 years, 9 months ago (2016-03-17 13:16:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 9 months ago (2016-03-17 14:39:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785173002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785173002/60001
4 years, 9 months ago (2016-03-17 14:52:54 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 9 months ago (2016-03-17 16:17:48 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 16:17:58 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22feaa3d15881c659d8fe1b49441649c0396d6a1
Cr-Commit-Position: refs/heads/master@{#12037}

Powered by Google App Engine
This is Rietveld 408576698