webrtc/modules/utility/source/process_thread_impl.h - Issue 1785173002: Replace scoped_ptr with unique_ptr in webrtc/modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/utility/source/process_thread_impl.h

Issue 1785173002: Replace scoped_ptr with unique_ptr in webrtc/modules/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@up8

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/utility/source/coder.h ('K') | « webrtc/modules/utility/source/helpers_ios.mm ('k') | webrtc/modules/utility/source/process_thread_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/utility/source/process_thread_impl.h

diff --git a/webrtc/modules/utility/source/process_thread_impl.h b/webrtc/modules/utility/source/process_thread_impl.h

index 1c0a0cdfdd71ec421e0ca70e7f73196fa1b5fc36..2855ed9d85038299d1eb0675d490720a29a901e5 100644

--- a/webrtc/modules/utility/source/process_thread_impl.h

+++ b/webrtc/modules/utility/source/process_thread_impl.h

@@ -12,6 +12,7 @@

#define WEBRTC_MODULES_UTILITY_SOURCE_PROCESS_THREAD_IMPL_H_

#include <list>

+#include <memory>

#include <queue>

#include "webrtc/base/criticalsection.h"

@@ -69,9 +70,9 @@ class ProcessThreadImpl : public ProcessThread {

rtc::CriticalSection lock_; // Used to guard modules_, tasks_ and stop_.

rtc::ThreadChecker thread_checker_;

- const rtc::scoped_ptr<EventWrapper> wake_up_;

- // TODO(pbos): Remove scoped_ptr and stop recreating the thread.

- rtc::scoped_ptr<rtc::PlatformThread> thread_;

+ const std::unique_ptr<EventWrapper> wake_up_;

+ // TODO(pbos): Remove unique_ptr and stop recreating the thread.

+ std::unique_ptr<rtc::PlatformThread> thread_;

ModuleList modules_;

// TODO(tommi): Support delayed tasks.