Bitexactness test for the noise suppressor

webrtc/modules/audio_processing/test/audio_buffer_tools.cc

Index: webrtc/modules/audio_processing/test/audio_buffer_tools.cc
diff --git a/webrtc/modules/audio_processing/test/audio_buffer_tools.cc b/webrtc/modules/audio_processing/test/audio_buffer_tools.cc
index a8cb09ca6a4b7a3da898163b647c8d42e9ce7d5f..71dc1278cdc6dd27a3b6b89e9c1a7815ac28993d 100644
--- a/webrtc/modules/audio_processing/test/audio_buffer_tools.cc
+++ b/webrtc/modules/audio_processing/test/audio_buffer_tools.cc
@@ -38,17 +38,14 @@ void CopyVectorToAudioBuffer(const StreamConfig& stream_config,
   destination->CopyFrom(&input[0], stream_config);
 }
 
-std::vector<float> ExtractVectorFromAudioBuffer(
-    const StreamConfig& stream_config,
-    AudioBuffer* source) {
+void ExtractVectorFromAudioBuffer(const StreamConfig& stream_config,
+                                  AudioBuffer* source,

[hlundin-webrtc, 2016/03/16 12:44:28]

Since you are changing the signature, can the input source be made const? I
realize that the CopyTo method is not const declared, but can it be?

[peah-webrtc, 2016/03/17 13:15:01]

Unfortunately not :-(. This is because the CopyTo command in AudioBuffer is not
const declared, and the reason for that is that it has an internal cache that it
updates depending on what kind of data has been accessed.

This is another motivation why audiobuffer should be refactored.

[hlundin-webrtc, 2016/03/17 14:14:40]

Acknowledged.

+                                  std::vector<float>* destination) {
   std::vector<float*> output;
-  std::vector<float> output_samples;
 
-  SetupFrame(stream_config, &output, &output_samples);
+  SetupFrame(stream_config, &output, destination);
 
   source->CopyTo(stream_config, &output[0]);
-
-  return output_samples;
 }
 
 }  // namespace test