Bitexactness test for the noise suppressor

webrtc/modules/audio_processing/test/audio_buffer_tools.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 20 matching lines @@
   std::vector<float> input_samples;
 
   SetupFrame(stream_config, &input, &input_samples);
 
   RTC_DCHECK_EQ(input_samples.size(), source.size());
   input_samples = source;
 
   destination->CopyFrom(&input[0], stream_config);
 }
 
-std::vector<float> ExtractVectorFromAudioBuffer(
-    const StreamConfig& stream_config,
-    AudioBuffer* source) {
+void ExtractVectorFromAudioBuffer(const StreamConfig& stream_config,
+                                  AudioBuffer* source,

[hlundin-webrtc, 2016/03/16 12:44:28]

Since you are changing the signature, can the input source be made const? I
realize that the CopyTo method is not const declared, but can it be?

[peah-webrtc, 2016/03/17 13:15:01]

Unfortunately not :-(. This is because the CopyTo command in AudioBuffer is not
const declared, and the reason for that is that it has an internal cache that it
updates depending on what kind of data has been accessed.

This is another motivation why audiobuffer should be refactored.

[hlundin-webrtc, 2016/03/17 14:14:40]

Acknowledged.

+                                  std::vector<float>* destination) {
   std::vector<float*> output;
-  std::vector<float> output_samples;
 
-  SetupFrame(stream_config, &output, &output_samples);
+  SetupFrame(stream_config, &output, destination);
 
   source->CopyTo(stream_config, &output[0]);
-
-  return output_samples;
 }
 
 }  // namespace test
 }  // namespace webrtc