Refactor VideoTracks to forward all sinks to its source

Refactor VideoTracks to forward all sinks to its source
This remove the use of VideoTrackRenderers within VideoTrack and instead all its sinks are passed to VideoSource.
That means that the source will handle all sinks and can (if the source implement it) handle different SinkWants for each sink.
The VideoBroadcaster is updated to produce black frames instead of as is today the deprecated VideoTrackRenderers.

BUG=webrtc:5426
R=nisse@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/d6c395441bf2866e2a99d726912292f67928999f
Cr-Commit-Position: refs/heads/master@{#12028}

[perkj_webrtc, 2016-03-10 17:53:37]

Description was changed from

==========
Refactor VideoTracks to forward all sinks to its source
This remove the use of VideoTrackRenderers within VideoTrack and instead all its
sinks are passed to VideoSource.
That means that the source will handle all sinks and can (if the source
implement it) handle different SinkWants for each sink.
The VideoBroadcaster is updated to produce black frames instead of as is today
the deprecated VideoTrackRenderers.

BUG=
==========

to

==========
Refactor VideoTracks to forward all sinks to its source
This remove the use of VideoTrackRenderers within VideoTrack and instead all its
sinks are passed to VideoSource.
That means that the source will handle all sinks and can (if the source
implement it) handle different SinkWants for each sink.
The VideoBroadcaster is updated to produce black frames instead of as is today
the deprecated VideoTrackRenderers.

BUG=webrtc:5426
==========

[perkj_webrtc, 2016-03-10 17:53:37]

perkj@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[perkj_webrtc, 2016-03-10 17:53:56]

Can you please review?

[pthatcher1, 2016-03-11 20:20:18]

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack.cc
File webrtc/api/videotrack.cc (right):

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack.cc#...
webrtc/api/videotrack.cc:78: }
Can we make a VideoSourceBase that implements a VideoSourceInterface?  That way,
the VideoBroadcaster and VideoTrack could both share the common
sinks_/find/add/remove logic.

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack_uni...
File webrtc/api/videotrack_unittest.cc (right):

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack_uni...
webrtc/api/videotrack_unittest.cc:64:
video_track_->RemoveSink(renderer_1.get());
Can we just do renderer_1.release() here, which removes itself when it's
destroyed?

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack_uni...
webrtc/api/videotrack_unittest.cc:69: // Need to re-add the
FakeVideoTrackRenderer since its de-register itself in
its de-register => it deregisters

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack_uni...
webrtc/api/videotrack_unittest.cc:92: 
Same here

[perkj_webrtc, 2016-03-11 21:44:57]

ptal

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack.cc
File webrtc/api/videotrack.cc (right):

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack.cc#...
webrtc/api/videotrack.cc:78: }
On 2016/03/11 20:20:17, pthatcher1 wrote:
> Can we make a VideoSourceBase that implements a VideoSourceInterface?  That
way,
> the VideoBroadcaster and VideoTrack could both share the common
> sinks_/find/add/remove logic.

Done.

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack_uni...
File webrtc/api/videotrack_unittest.cc (right):

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack_uni...
webrtc/api/videotrack_unittest.cc:64:
video_track_->RemoveSink(renderer_1.get());
On 2016/03/11 20:20:18, pthatcher1 wrote:
> Can we just do renderer_1.release() here, which removes itself when it's
> destroyed?

Done.

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack_uni...
webrtc/api/videotrack_unittest.cc:69: // Need to re-add the
FakeVideoTrackRenderer since its de-register itself in
On 2016/03/11 20:20:17, pthatcher1 wrote:
> its de-register => it deregisters

removed

https://codereview.webrtc.org/1779063003/diff/40001/webrtc/api/videotrack_uni...
webrtc/api/videotrack_unittest.cc:92: 
On 2016/03/11 20:20:17, pthatcher1 wrote:
> Same here

Done.

[pthatcher1, 2016-03-12 01:25:59]

lgtm

[nisse-webrtc, 2016-03-16 13:43:56]

nisse@webrtc.org changed reviewers:
+ nisse@webrtc.org

[nisse-webrtc, 2016-03-16 13:43:57]

https://codereview.webrtc.org/1779063003/diff/80001/webrtc/media/base/videobr...
File webrtc/media/base/videobroadcaster.cc (right):

https://codereview.webrtc.org/1779063003/diff/80001/webrtc/media/base/videobr...
webrtc/media/base/videobroadcaster.cc:94: current_wants_ = wants;
So black_frame is always ignored here? It would make some sense to set
wants.black_frames = ANY(sinks.wants.black_frames), but it might not matter.

[pthatcher1, 2016-03-16 15:14:05]

https://codereview.webrtc.org/1779063003/diff/80001/webrtc/media/base/videobr...
File webrtc/media/base/videobroadcaster.cc (right):

https://codereview.webrtc.org/1779063003/diff/80001/webrtc/media/base/videobr...
webrtc/media/base/videobroadcaster.cc:94: current_wants_ = wants;
On 2016/03/16 13:43:56, nisse-webrtc wrote:
> So black_frame is always ignored here? It would make some sense to set
> wants.black_frames = ANY(sinks.wants.black_frames), but it might not matter.

Some sinks may want black frames and others not.

[nisse-webrtc, 2016-03-17 08:45:25]

lgtm

[perkj_webrtc, 2016-03-17 08:48:35]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-03-17 08:48:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1779063003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1779063003/80001

[commit-bot: I haz the power, 2016-03-17 09:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 09:14:50]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[perkj_webrtc, 2016-03-17 09:18:22]

The CQ bit was checked by perkj@webrtc.org

[perkj_webrtc, 2016-03-17 09:18:22]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1779063003/#ps100001 (title:
"Rebased")

[commit-bot: I haz the power, 2016-03-17 09:18:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1779063003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1779063003/100001

[commit-bot: I haz the power, 2016-03-17 09:28:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 09:28:41]

Try jobs failed on following builders:
  win_drmemory_light on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/buil...)

[perkj_webrtc, 2016-03-17 09:35:58]

Description was changed from

==========
Refactor VideoTracks to forward all sinks to its source
This remove the use of VideoTrackRenderers within VideoTrack and instead all its
sinks are passed to VideoSource.
That means that the source will handle all sinks and can (if the source
implement it) handle different SinkWants for each sink.
The VideoBroadcaster is updated to produce black frames instead of as is today
the deprecated VideoTrackRenderers.

BUG=webrtc:5426
==========

to

==========
Refactor VideoTracks to forward all sinks to its source
This remove the use of VideoTrackRenderers within VideoTrack and instead all its
sinks are passed to VideoSource.
That means that the source will handle all sinks and can (if the source
implement it) handle different SinkWants for each sink.
The VideoBroadcaster is updated to produce black frames instead of as is today
the deprecated VideoTrackRenderers.

BUG=webrtc:5426
R=nisse@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/d6c395441bf2866e2a99d7269...
==========

[commit-bot: I haz the power, 2016-03-17 09:36:00]

Description was changed from

==========
Refactor VideoTracks to forward all sinks to its source
This remove the use of VideoTrackRenderers within VideoTrack and instead all its
sinks are passed to VideoSource.
That means that the source will handle all sinks and can (if the source
implement it) handle different SinkWants for each sink.
The VideoBroadcaster is updated to produce black frames instead of as is today
the deprecated VideoTrackRenderers.

BUG=webrtc:5426
R=nisse@webrtc.org, pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/d6c395441bf2866e2a99d7269...
==========

to

==========
Refactor VideoTracks to forward all sinks to its source
This remove the use of VideoTrackRenderers within VideoTrack and instead all its
sinks are passed to VideoSource.
That means that the source will handle all sinks and can (if the source
implement it) handle different SinkWants for each sink.
The VideoBroadcaster is updated to produce black frames instead of as is today
the deprecated VideoTrackRenderers.

BUG=webrtc:5426
R=nisse@webrtc.org, pthatcher@webrtc.org

Committed: https://crrev.com/d6c395441bf2866e2a99d726912292f67928999f
Cr-Commit-Position: refs/heads/master@{#12028}
==========

[commit-bot: I haz the power, 2016-03-17 09:36:01]

Patchset 6 (id:??) landed as
https://crrev.com/d6c395441bf2866e2a99d726912292f67928999f
Cr-Commit-Position: refs/heads/master@{#12028}

[perkj_webrtc, 2016-03-17 09:36:01]

Committed patchset #6 (id:100001) manually as
d6c395441bf2866e2a99d726912292f67928999f (presubmit successful).