Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: talk/app/webrtc/objctests/RTCPeerConnectionTest.mm

Issue 1779063003: Refactor VideoTracks to forward all sinks to its source (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/api.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/objctests/RTCPeerConnectionTest.mm
diff --git a/talk/app/webrtc/objctests/RTCPeerConnectionTest.mm b/talk/app/webrtc/objctests/RTCPeerConnectionTest.mm
index c43a6fcf24676f513ed4d6116935c67563119551..f447ae9ba83c9c73c63d0bbbd7c5bb8c00ec6da9 100644
--- a/talk/app/webrtc/objctests/RTCPeerConnectionTest.mm
+++ b/talk/app/webrtc/objctests/RTCPeerConnectionTest.mm
@@ -90,14 +90,18 @@ const NSTimeInterval kRTCPeerConnectionTestTimeout = 20;
videoTrackID:(NSString*)videoTrackID
audioTrackID:(NSString*)audioTrackID {
RTCMediaStream* localMediaStream = [factory mediaStreamWithLabel:streamLabel];
- RTCVideoTrack* videoTrack =
- [factory videoTrackWithID:videoTrackID source:videoSource];
- RTCFakeRenderer* videoRenderer = [[RTCFakeRenderer alloc] init];
- [videoTrack addRenderer:videoRenderer];
- [localMediaStream addVideoTrack:videoTrack];
- // Test that removal/re-add works.
- [localMediaStream removeVideoTrack:videoTrack];
- [localMediaStream addVideoTrack:videoTrack];
+ // TODO(zeke): Fix this test to create a fake video capturer so that a track
+ // can be created.
+ if (videoSource) {
+ RTCVideoTrack* videoTrack =
+ [factory videoTrackWithID:videoTrackID source:videoSource];
+ RTCFakeRenderer* videoRenderer = [[RTCFakeRenderer alloc] init];
+ [videoTrack addRenderer:videoRenderer];
+ [localMediaStream addVideoTrack:videoTrack];
+ // Test that removal/re-add works.
+ [localMediaStream removeVideoTrack:videoTrack];
+ [localMediaStream addVideoTrack:videoTrack];
+ }
RTCAudioTrack* audioTrack = [factory audioTrackWithID:audioTrackID];
[localMediaStream addAudioTrack:audioTrack];
[pc addStream:localMediaStream];
« no previous file with comments | « no previous file | webrtc/api/api.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698