Chromium Code Reviews| Index: webrtc/modules/video_coding/include/video_coding.h |
| diff --git a/webrtc/modules/video_coding/include/video_coding.h b/webrtc/modules/video_coding/include/video_coding.h |
| index 6433f5628d044f9e88a015c252588b2673044e09..50efc4250fceb47e3a1334e3a2088117ca2c417a 100644 |
| --- a/webrtc/modules/video_coding/include/video_coding.h |
| +++ b/webrtc/modules/video_coding/include/video_coding.h |
| @@ -68,13 +68,34 @@ class VideoCodingModule : public Module { |
| enum ReceiverRobustness { kNone, kHardNack, kSoftNack, kReferenceSelection }; |
| + // Create method for current interface, will be removed when the |
| + // new jitter buffer is in place. |
| static VideoCodingModule* Create( |
| Clock* clock, |
| VideoEncoderRateObserver* encoder_rate_observer, |
| VCMQMSettingsCallback* qm_settings_callback); |
| + // Create method for the new jitter buffer. |
|
stefan-webrtc
2016/03/10 14:20:40
I think you can remove these comments mentioning t
philipel
2016/03/10 16:39:27
Done.
|
| + static VideoCodingModule* Create( |
| + Clock* clock, |
| + VideoEncoderRateObserver* encoder_rate_observer, |
| + VCMQMSettingsCallback* qm_settings_callback, |
| + ProcessThread* module_process_thread, |
|
stefan-webrtc
2016/03/10 14:20:40
I think it's easier to simply have the VideoCoding
philipel
2016/03/10 16:39:27
:(((((((((((((((((((((((((((
|
| + NackSender* nack_sender, |
| + KeyFrameRequestSender* keyframe_request_sender); |
| + |
| + // Create method for current interface, will be removed when the |
| + // new jitter buffer is in place. |
| static VideoCodingModule* Create(Clock* clock, EventFactory* event_factory); |
| + // Create method for the new jitter buffer. |
| + static VideoCodingModule* Create( |
| + Clock* clock, |
| + EventFactory* event_factory, |
| + ProcessThread* module_process_thread, |
| + NackSender* nack_sender, |
| + KeyFrameRequestSender* keyframe_request_sender); |
| + |
| // Get supported codec settings using codec type |
| // |
| // Input: |